[dead-code] chore: remove dead functions — 1 function removed

[github-actions]

-> Generated by PR Description Updater for #54835 · auto · 53 AIC · ⌖ 4 AIC · ⊞ 7.6K · ◷

[github-actions]

✅ Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #54835

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #54835 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

[github-actions]

Comment Memory

reviewed_at: 2026-08-22T00:00:00Z
review_event: COMMENT
top_themes:
  - no actionable issues; dead-code removal is internally consistent
files_reviewed:
  - pkg/actionpins/actionpins_internal_test.go
  - pkg/actionpins/data.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 2.21 AIC · ⌖ 6.75 AIC · ⊞ 7K · ◷
_{Comment /review to run again}

[github-actions]

Verdict

Comment only: this change is a clean dead-code removal and I did not find a correctness, performance, or maintainability regression in the changed lines.

Reviewed scope

• pkg/actionpins/data.go
• pkg/actionpins/actionpins_internal_test.go

The patch removes an unreferenced wrapper (getActionPins) and its now-redundant test. The remaining cache path still has direct coverage via getCachedActionPins() tests, and there is no behavior change in production code.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 2.21 AIC · ⌖ 6.75 AIC · ⊞ 7K
_{Comment /review to run again}

[github-actions]

Skills-Based Review 🧠

Applied /codebase-design — no issues found; approving.

The removal of getActionPins() is correct: it was a one-liner wrapper around getCachedActionPins().pins with no callers. Removing it simplifies the API surface, and the accompanying test exclusively exercised this dead wrapper, so its removal is appropriate.

✅ Clean deletion with no collateral risk.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 16.7 AIC · ⌖ 9.67 AIC · ⊞ 7.6K
_{Comment /matt to run again}

[Copilot]

Pull request overview

Removes an unused internal action-pin cache accessor and its dedicated test.

Changes:

• Deletes getActionPins.
• Deletes its repeated-call cache test.

Show a summary per file

File	Description
pkg/actionpins/data.go	Removes the unused accessor.
pkg/actionpins/actionpins_internal_test.go	Removes the accessor-specific test.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Balanced

[github-actions]

Clean dead-code removal. getActionPins() was a thin wrapper with no remaining callers; removing it and its test is correct. No issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 13.2 AIC · ⌖ 8.94 AIC · ⊞ 6.2K

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.5