Skip to content

Rename panic-in-library-code internals for intent-driven discoverability #54795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Aug 22, 2026
Merged

Rename panic-in-library-code internals for intent-driven discoverability #54795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93178e4
Initial plan
Copilot Aug 22, 2026
6fb8cef
Rename panic-in-library-code helper functions for clarity
Copilot Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions pkg/linters/panic-in-library-code/panic-in-library-code.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ import (
var pkgLog = logger.New("linters:panicinlibrarycode")

// Analyzer is the panic-in-library-code analysis pass.
var Analyzer = analyzerutil.NewAtPath("panicinlibrarycode", "reports panic() calls in library code under pkg/ that should return errors instead", "panic-in-library-code", run)
var Analyzer = analyzerutil.NewAtPath("panicinlibrarycode", "reports panic() calls in library code under pkg/ that should return errors instead", "panic-in-library-code", analyzePanicCalls)

func run(pass *analysis.Pass) (any, error) {
func analyzePanicCalls(pass *analysis.Pass) (any, error) {
insp, err := astutil.Inspector(pass)
if err != nil {
return nil, err
Expand Down Expand Up @@ -97,7 +97,7 @@ func isInSyncOnceFuncLit(pass *analysis.Pass, cur inspector.Cursor) bool {
}
parent := encl.Parent()
call, ok := parent.Node().(*ast.CallExpr)
if !ok || !containsExpr(call.Args, funcLit) {
if !ok || !callArgsContainExpr(call.Args, funcLit) {
continue
}
sel, ok := selectorExprFromCallFun(call.Fun)
Expand Down Expand Up @@ -148,7 +148,7 @@ func isSyncOnceConstructorCall(pass *analysis.Pass, sel *ast.SelectorExpr) bool
return isSyncPackageFunc(pass, sel, "OnceValue", "OnceFunc")
}

func containsExpr(args []ast.Expr, target ast.Expr) bool {
func callArgsContainExpr(args []ast.Expr, target ast.Expr) bool {
return slices.Contains(args, target)
}

Expand All @@ -170,15 +170,15 @@ func panicMessageStartsWithBUG(pass *analysis.Pass, call *ast.CallExpr) bool {
return false
}

prefix, ok := stringPrefix(pass, call.Args[0])
prefix, ok := extractConstantStringPrefix(pass, call.Args[0])
if !ok {
return false
}

return strings.HasPrefix(strings.ToUpper(strings.TrimSpace(prefix)), "BUG:")
}

func stringPrefix(pass *analysis.Pass, expr ast.Expr) (string, bool) {
func extractConstantStringPrefix(pass *analysis.Pass, expr ast.Expr) (string, bool) {
if tv, ok := pass.TypesInfo.Types[expr]; ok && tv.Value != nil && tv.Value.Kind() == constant.String {
return constant.StringVal(tv.Value), true
}
Expand All @@ -188,7 +188,7 @@ func stringPrefix(pass *analysis.Pass, expr ast.Expr) (string, bool) {
if e.Op != token.ADD {
return "", false
}
return stringPrefix(pass, e.X)
return extractConstantStringPrefix(pass, e.X)
case *ast.CallExpr:
if len(e.Args) == 0 {
return "", false
Expand All @@ -198,7 +198,7 @@ func stringPrefix(pass *analysis.Pass, expr ast.Expr) (string, bool) {
if !isFmtSprintf(pass, e) {
return "", false
}
return stringPrefix(pass, e.Args[0])
return extractConstantStringPrefix(pass, e.Args[0])
default:
return "", false
}
Expand Down
Loading