Restore errormessage CI coverage - #54355
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI gate status for error-message-lint
Restore errormessage CI coverage
Aug 20, 2026
pelikhan
marked this pull request as ready for review
August 20, 2026 21:35
Contributor
There was a problem hiding this comment.
Pull request overview
Restores active CI enforcement for the errormessage analyzer.
Changes:
- Enables explicit
errormessageanalysis in the standalone workflow. - Adds changed-file linting for pull requests and pushes to CGO CI.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/error-message-lint.yml |
Explicitly enables the analyzer. |
.github/workflows/cgo.yml |
Adds changed-file scope and lint gate. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+1390
to
+1398
| elif [ "$EVENT_NAME" = "push" ] && [ -n "$BEFORE_SHA" ] && [ "$BEFORE_SHA" != "0000000000000000000000000000000000000000" ]; then | ||
| if git rev-parse --verify "$BEFORE_SHA^{commit}" >/dev/null 2>&1; then | ||
| # Push events compare the before and after commit trees directly; | ||
| # PR events use base...HEAD above to match GitHub's pull request diff. | ||
| files=$(git diff --name-only "$BEFORE_SHA" HEAD -- '*.go' | tr '\n' ',' | sed 's/,$//') | ||
| else | ||
| echo "Before SHA $BEFORE_SHA not found, skipping push diff" | ||
| fi | ||
| fi |
Contributor
|
🎉 This pull request is included in a new release. Release: |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errormessagewas registered and remediated, but its only dedicated CI workflow has been manually disabled since May. This left new Go error-message violations without a live CI signal.Active CI coverage
errormessagechanged-file gate to the active CGO workflow.base...HEADdiffs and push before/after tree diffs to scope checks to changed.gofiles.Standalone workflow correctness
error-message-lint.ymlto explicitly run only theerrormessageanalyzer./tmp/gh-aw-linters -errormessage -errormessage.changed-files="$CHANGED_GO_FILES" ./...