Skip to content

Enable cloud-hypervisor sandbox runtime for copilot, claude, and gemini smoke workflows - #53133

Merged
pelikhan merged 1 commit into
mainfrom
copilot/update-agentic-workflows-cloud-hypervisor
Aug 16, 2026
Merged

Enable cloud-hypervisor sandbox runtime for copilot, claude, and gemini smoke workflows#53133
pelikhan merged 1 commit into
mainfrom
copilot/update-agentic-workflows-cloud-hypervisor

Conversation

Copilot AI commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Onboards three of the four agentic engines onto the preview cloud-hypervisor sandbox runtime, and fixes a compiler gap that made this impossible for gemini.

  • Runtime opt-in

    • smoke-test-tools.md (copilot) and smoke-agent-all-merged.md (claude): set sandbox.agent.runtime: cloud-hypervisor.
    • smoke-gemini.md (gemini): set sandbox.agent.runtime: cloud-hypervisor; dropped the shared/gh.md import, which forced tools.github.mode: gh-proxy — incompatible with cloud-hypervisor and unused by the workflow body.
  • Compiler fix — missing gemini firewall default

    • pkg/workflow/firewall.go auto-enables the AWF firewall by default per engine (enableFirewallByDefaultForCopilot/Claude/Pi), but had no gemini equivalent. Without it, NetworkPermissions.Firewall stayed nil, so the cloud-hypervisor setup step emitted an empty GH_AW_AWF_VERSION, which fails schema validation as null:

      GH_AW_AWF_VERSION:   # empty -> null -> schema validation failure
      
    • Added enableFirewallByDefaultForGemini, mirroring the existing per-engine functions, and wired it into compiler_orchestrator_engine.go.

    • Added TestEnableFirewallByDefaultForGemini and regenerated the gemini wasm golden fixture to reflect the firewall now being enabled by default.

  • Out of scope: pi

    • pi has no native MCP support and unconditionally requires tools.github.mode: gh-proxy + cli-proxy: true (agent_validation.go). Cloud-hypervisor's topology has no CLI-proxy sidecar and explicitly rejects gh-proxy/cli-proxy (sandbox_validation.go). This is intentional, enforced validation, so no pi workflow can adopt cloud-hypervisor yet — flagging for visibility rather than working around it.

…orkflows; fix gemini firewall auto-enable gap

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Update agentic workflows to use cloud-hypervisor sandbox runtime Enable cloud-hypervisor sandbox runtime for copilot, claude, and gemini smoke workflows Aug 16, 2026
Copilot AI requested a review from pelikhan August 16, 2026 13:25
@pelikhan
pelikhan marked this pull request as ready for review August 16, 2026 13:29
Copilot AI balanced review requested due to automatic review settings August 16, 2026 13:30
@pelikhan
pelikhan merged commit df9f5b9 into main Aug 16, 2026
@pelikhan
pelikhan deleted the copilot/update-agentic-workflows-cloud-hypervisor branch August 16, 2026 13:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables cloud-hypervisor for Copilot, Claude, and Gemini smoke workflows while adding Gemini’s missing default firewall enablement.

Changes:

  • Opts three smoke workflows into cloud-hypervisor.
  • Enables AWF by default for Gemini.
  • Updates tests, golden output, and compiled workflows.
Show a summary per file
File Description
pkg/workflow/firewall.go Adds Gemini firewall defaults.
pkg/workflow/compiler_orchestrator_engine.go Applies the Gemini default.
pkg/workflow/firewall_default_enablement_test.go Tests Gemini firewall behavior.
pkg/workflow/testdata/TestWasmGolden_AllEngines/gemini.golden Updates Gemini golden output.
.github/workflows/smoke-gemini.md Enables cloud-hypervisor and removes gh-proxy.
.github/workflows/smoke-gemini.lock.yml Regenerates the Gemini workflow.
.github/workflows/smoke-agent-all-merged.md Enables cloud-hypervisor for Claude.
.github/workflows/smoke-agent-all-merged.lock.yml Regenerates the Claude workflow.
.github/workflows/smoke-test-tools.md Enables cloud-hypervisor for Copilot.
.github/workflows/smoke-test-tools.lock.yml Regenerates the Copilot workflow.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 10/10 changed files
  • Comments generated: 1
  • Review effort level: Balanced

sandbox:
agent:
id: awf
runtime: cloud-hypervisor
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.87.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants