Harden Avenger against transient Claude harness failure exhaustion - #53043
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #53043 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).
|
|
✅ Ponytail Reviewer completed successfully! Trivial one-line config change (adds GH_AW_HARNESS_MAX_RETRIES env var) plus its auto-generated lock file mirror. Nothing to cut. Lean already. Ship.
|
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped. (PR #53043 only modified workflow markdown and lock files)
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
Great work! 🎯 This PR looks ready for review. This fix addresses a concrete issue in the Avenger CI workflow where transient Claude harness failures were exhausting the retry budget too quickly, preventing recovery from subsequent transport-level errors. Your solution — adding one additional retry attempt via Why this works:
The fix is well-documented, focused, and follows the agentic development process for this repository. Ready to move forward.
|
There was a problem hiding this comment.
Pull request overview
Increases Avenger’s Claude harness retry budget to better tolerate transient failures.
Changes:
- Raises harness retries from 3 to 4.
- Regenerates the compiled workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/avenger.md |
Adds the retry override. |
.github/workflows/avenger.lock.yml |
Synchronizes compiled workflow output. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment.
|
There was a problem hiding this comment.
Verdict
Non-blocking change: this only increases Avenger's harness retry budget and keeps the compiled workflow in sync.
The changed lines do not introduce a correctness, security, or maintainability problem that warrants blocking the PR.
I reviewed the source workflow change and the regenerated lockfile. The diff is limited to setting GH_AW_HARNESS_MAX_RETRIES to 4 for this workflow and updating generated metadata accordingly. I did not find an actionable bug on the changed lines.
🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 2.74 AIC · ⌖ 5.37 AIC · ⊞ 6.9K
Comment /review to run again
There was a problem hiding this comment.
LGTM. Adds GH_AW_HARNESS_MAX_RETRIES: 4 to both avenger.md and the compiled avenger.lock.yml to harden against transient Claude harness failure exhaustion. The frontmatter hash in the lock file metadata is correctly updated to match.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 17.2 AIC · ⌖ 7.01 AIC · ⊞ 5.6K
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /diagnosing-bugs — approving this targeted fix.
📋 Review Notes
Assessment
- ✅ Root cause is clearly identified: transient Claude crash sequences were consuming the full retry budget (default
3), leaving no headroom for a subsequent transport-level failure - ✅ Fix is surgical: one env variable in
avenger.md, lock file regenerated correctly - ✅ The
GH_AW_HARNESS_MAX_RETRIESknob is the correct lever — documented indocs/src/content/docs/reference/environment-variables.md, tested inclaude_harness.test.cjs - ✅ Metadata hash in lock file updated, confirming proper
gh aw recompilewas run
One observation (non-blocking)
The PR description explains the cascade failure well, but a brief inline comment in avenger.md (e.g. # Increased from default 3 to absorb transient Claude crash sequences) would help future readers understand the intent without tracing back to this PR.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 25.9 AIC · ⌖ 8.37 AIC · ⊞ 7.7K
Comment /matt to run again
|
🎉 This pull request is included in a new release. Release: |
Avenger failed when repeated Claude runtime crashes consumed the retry budget, leaving no room to recover from a subsequent transport-level invalid JSON request-body failure. This change increases retry headroom for that workflow so transient crash sequences are less likely to terminate the run early.
Workflow runtime guardrail adjustment
avenger.md:GH_AW_HARNESS_MAX_RETRIES: "4"Compiled workflow synchronization
avenger.lock.ymlso compiled workflow behavior matches frontmatter source.