Skip to content

Harden Avenger against transient Claude harness failure exhaustion - #53043

Merged
pelikhan merged 2 commits into
mainfrom
copilot/aw-avenger-failed-fix
Aug 16, 2026
Merged

Harden Avenger against transient Claude harness failure exhaustion#53043
pelikhan merged 2 commits into
mainfrom
copilot/aw-avenger-failed-fix

Conversation

Copilot AI commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Avenger failed when repeated Claude runtime crashes consumed the retry budget, leaving no room to recover from a subsequent transport-level invalid JSON request-body failure. This change increases retry headroom for that workflow so transient crash sequences are less likely to terminate the run early.

  • Workflow runtime guardrail adjustment

    • Added a workflow-level env override in avenger.md:
      • GH_AW_HARNESS_MAX_RETRIES: "4"
    • This gives the Claude harness one additional retry attempt in Avenger runs.
  • Compiled workflow synchronization

    • Regenerated avenger.lock.yml so compiled workflow behavior matches frontmatter source.
env:
  GOTOOLCHAIN: auto
  GH_AW_HARNESS_MAX_RETRIES: "4"

Copilot AI linked an issue Aug 16, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix workflow failure in Avenger due to engine termination Harden Avenger against transient Claude harness failure exhaustion Aug 16, 2026
Copilot AI requested a review from pelikhan August 16, 2026 05:02
@pelikhan
pelikhan marked this pull request as ready for review August 16, 2026 05:03
Copilot AI balanced review requested due to automatic review settings August 16, 2026 05:03
@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #53043 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Ponytail Reviewer completed successfully!

Trivial one-line config change (adds GH_AW_HARNESS_MAX_RETRIES env var) plus its auto-generated lock file mirror. Nothing to cut. Lean already. Ship.

Generated by Ponytail Reviewer for #53043

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped. (PR #53043 only modified workflow markdown and lock files)

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

Copy link
Copy Markdown
Contributor

Great work! 🎯 This PR looks ready for review.

This fix addresses a concrete issue in the Avenger CI workflow where transient Claude harness failures were exhausting the retry budget too quickly, preventing recovery from subsequent transport-level errors. Your solution — adding one additional retry attempt via GH_AW_HARNESS_MAX_RETRIES: "4" — is focused and minimal.

Why this works:

  • Increases retry headroom for the harness, reducing the likelihood of early termination when facing rapid failure sequences
  • Compiled workflow sync is correct (.lock.yml properly regenerated from .md)
  • Validation checklist in the PR body confirms targeted testing

The fix is well-documented, focused, and follows the agentic development process for this repository. Ready to move forward.

Generated by ✅ Contribution Check · auto · 65.6 AIC · ⌖ 3.96 AIC · ⊞ 9.1K ·

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Increases Avenger’s Claude harness retry budget to better tolerate transient failures.

Changes:

  • Raises harness retries from 3 to 4.
  • Regenerates the compiled workflow.
Show a summary per file
File Description
.github/workflows/avenger.md Adds the retry override.
.github/workflows/avenger.lock.yml Synchronizes compiled workflow output.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Comment Memory

reviewed_at: 2026-08-16T00:00:00Z
review_event: COMMENT
top_themes:
  - workflow retry budget increase only
  - no changed-line correctness or security regressions found
files_reviewed:
  - .github/workflows/avenger.md
  - .github/workflows/avenger.lock.yml
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 2.74 AIC · ⌖ 5.37 AIC · ⊞ 6.9K ·
Comment /review to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

Non-blocking change: this only increases Avenger's harness retry budget and keeps the compiled workflow in sync.

The changed lines do not introduce a correctness, security, or maintainability problem that warrants blocking the PR.

I reviewed the source workflow change and the regenerated lockfile. The diff is limited to setting GH_AW_HARNESS_MAX_RETRIES to 4 for this workflow and updating generated metadata accordingly. I did not find an actionable bug on the changed lines.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 2.74 AIC · ⌖ 5.37 AIC · ⊞ 6.9K
Comment /review to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adds GH_AW_HARNESS_MAX_RETRIES: 4 to both avenger.md and the compiled avenger.lock.yml to harden against transient Claude harness failure exhaustion. The frontmatter hash in the lock file metadata is correctly updated to match.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 17.2 AIC · ⌖ 7.01 AIC · ⊞ 5.6K

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /diagnosing-bugs — approving this targeted fix.

📋 Review Notes

Assessment

  • ✅ Root cause is clearly identified: transient Claude crash sequences were consuming the full retry budget (default 3), leaving no headroom for a subsequent transport-level failure
  • ✅ Fix is surgical: one env variable in avenger.md, lock file regenerated correctly
  • ✅ The GH_AW_HARNESS_MAX_RETRIES knob is the correct lever — documented in docs/src/content/docs/reference/environment-variables.md, tested in claude_harness.test.cjs
  • ✅ Metadata hash in lock file updated, confirming proper gh aw recompile was run

One observation (non-blocking)

The PR description explains the cascade failure well, but a brief inline comment in avenger.md (e.g. # Increased from default 3 to absorb transient Claude crash sequences) would help future readers understand the intent without tracing back to this PR.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 25.9 AIC · ⌖ 8.37 AIC · ⊞ 7.7K
Comment /matt to run again

@github-actions github-actions Bot mentioned this pull request Aug 16, 2026
@pelikhan
pelikhan merged commit b29c796 into main Aug 16, 2026
48 of 49 checks passed
@pelikhan
pelikhan deleted the copilot/aw-avenger-failed-fix branch August 16, 2026 05:19
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.87.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Avenger failed

3 participants