Enforce regexpdynamicpattern linter in CI (cgo.yml) - #52954
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add regexpdynamicpattern linter to CI enforcement
Enforce regexpdynamicpattern linter in CI (cgo.yml)
Aug 15, 2026
pelikhan
marked this pull request as ready for review
August 15, 2026 19:23
Contributor
There was a problem hiding this comment.
Pull request overview
Enforces the existing regexpdynamicpattern analyzer in CI.
Changes:
- Enables the analyzer for native and WASM custom-linter runs.
- Retains production-only analysis via
-test=false.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Adds -regexpdynamicpattern to both enforced linter configurations. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regexpdynamicpatternflagsregexp.Compile/MustCompile/CompilePOSIX/MustCompilePOSIXcalls with dynamically-built patterns that can't be validated at compile time. The linter is type-resolved and correct, but was never added to the CI-enforcedLINTER_FLAGSincgo.yml, so it ran advisory-only.-regexpdynamicpatternto bothLINTER_FLAGSdefinitions in.github/workflows/cgo.yml(the default run and theGOOS=js GOARCH=wasmvariant)../pkg/console ./pkg/parser ./pkg/styles ./pkg/tty ./pkg/workflow) viamake golint-custom LINTER_FLAGS="-regexpdynamicpattern -test=false" LINTER_PACKAGES="./pkg/console ./pkg/parser ./pkg/styles ./pkg/tty ./pkg/workflow"— all known dynamic-pattern sites already carry justifiednolint:regexpdynamicpatternsuppressions.