hardcodedfilepath: include same-package unexported consts in reuse suggestions

[Copilot]

collectKnownPathConsts applied an exported-only filter to both imported constants and current-package constants. That caused same-package duplicates of unexported path constants to be misdiagnosed as “extract a new constant” instead of “reuse existing constant”.

• Behavioral fix: scope-aware constant visibility

  • Updated collectKnownPathConsts to treat visibility differently by source:
    • current package scope: include exported + unexported constants
    • imported *constants* packages: keep exported-only filtering

• Regression coverage: same-package unexported reuse path

  • Added analyzer testdata case with a second use of an unexported local path constant.
  • Expected diagnostic now asserts reuse of localPathConst (not extraction of a new constant).

// current package constants: no exported-only gate
addConst(c, "", name, false)

// imported constants packages: exported-only gate preserved
addConst(c, alias, name, true)

• Fixes hardcodedfilepath: Exported()-only const filter excludes same-package unexported constants, causing misleading 'extract new cons [Content truncated due to length] #52428

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.49 AIC · ⌖ 5.77 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

[Copilot]

Pull request overview

Fixes scope-aware constant reuse suggestions in the hardcodedfilepath analyzer.

Changes:

• Includes unexported constants from the current package.
• Preserves exported-only filtering for imported constants.
• Adds regression coverage for local unexported constant reuse.

Show a summary per file

File	Description
pkg/linters/hardcodedfilepath/hardcodedfilepath.go	Applies source-specific visibility filtering.
pkg/linters/hardcodedfilepath/testdata/src/hardcodedfilepath/hardcodedfilepath.go	Tests reuse of an unexported local constant.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

[gh-aw-bot]

@copilot All checks are green, but this PR still needs a maintainer-ready finish.

Please refresh the branch if needed and run the pr-finisher skill so the PR is ready for investigation.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.49 AIC · ⌖ 5.77 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

[Copilot]

@copilot All checks are green, but this PR still needs a maintainer-ready finish.

Please refresh the branch if needed and run the pr-finisher skill so the PR is ready for investigation....

Refreshed the branch with current main in 59cf9b9 and completed the pr-finisher validation pass (make fmt, make lint, make test, make recompile, and make agent-report-progress). No unresolved review threads remain.

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.0