Cover untested Resolver branches in pkg/intent/resolver_test.go

[Copilot]

resolver_test.go exercised only the ResolvePullRequest closing-issue/artifact/ambiguous paths. The explicit-intent branch, most of ResolveIssue, and statusForLabels's MatchLabels == nil case had no direct coverage, and the unlinked/ambiguous tests asserted only non-zero fields.

Test-only change; resolver.go is untouched.

New tests

• Explicit intent — ResolvePullRequest returns the record as-is when ResolverVersion is set, and fills it from the resolver when blank. Also asserts the caller's record is not mutated (relies on the value copy in resolver.go:74).
• ResolveIssue — no labels → unlinked, unmapped labels, and cloneStrings isolation (mutating the caller's slice after the call does not affect intent.Labels).
• statusForLabels with nil MatchLabels — covered from both entry points (PR artifact-label fallback and ResolveIssue), which previously fell through untested to AttributionUnmapped.

Tightened existing assertions

TestResolverResolvePullRequestNoSourcesUnlinked and ...MultipleClosingIssuesAmbiguous now compare the whole struct, so zero-value fields are asserted and unexpected fields are caught:

assert.Equal(t, IntentRecord{
	Status:          AttributionAmbiguous,
	Source:          SourceClosingIssue,
	Rule:            "multiple_closing_issues",
	ResolverVersion: "test-v1",
}, intent)

Both resolvers now set an explicit ResolverVersion so that field participates in the comparison rather than matching the zero value by accident.

The optional table-driven refactor and t.Run regrouping from the issue were skipped to keep the diff additive; the existing one-function-per-branch layout stays consistent with the rest of the package.

• Fixes [testify-expert] Improve Test Quality: pkg/intent/resolver_test.go #52938

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.49 AIC · ⌖ 5.77 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

[github-actions]

PR Triage

• Category: test | Risk: low | Score: 20/100 (Impact 5, Urgency 5, Quality 10)
• Action: defer
• WIP/draft PR with 0 diff so far (branch not yet populated). Revisit once commits land.

Generated by 🔧 PR Triage Agent · auto · 37.4 AIC · ⌖ 2.04 AIC · ⊞ 8.1K · ◷

[Copilot]

Pull request overview

Adds direct coverage for previously untested resolver branches and strengthens assertions.

Changes:

• Tests explicit-intent version handling and immutability.
• Covers ResolveIssue, nil matchers, and label cloning.
• Uses full-record assertions for unlinked and ambiguous results.

Show a summary per file

File	Description
pkg/intent/resolver_test.go	Expands resolver branch coverage and tightens expected results.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Balanced

[gh-aw-bot]

@copilot Maintainers will want another pass here before investigating.

Please refresh the branch, fix the failing check, and then run the pr-finisher skill.

Failed checks:

• Unit tests (M-R): https://github.com/github/gh-aw/actions/runs/31900980872/job/95056995167

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.49 AIC · ⌖ 5.77 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.0