Accept Alpine base OS packages as a documented grant license policy exception - #52904
Merged
Conversation
…xception Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update golang dependencies for grafana/mcp-grafana
Accept Alpine base OS packages as a documented grant license policy exception
Aug 15, 2026
pelikhan
marked this pull request as ready for review
August 15, 2026 14:37
Contributor
There was a problem hiding this comment.
Pull request overview
Documents and configures license exceptions for Alpine base-image packages detected during container scans.
Changes:
- Adds Grant package-name exclusions for 12 Alpine packages.
- Documents the container base OS exception policy.
Show a summary per file
| File | Description |
|---|---|
.grant.yaml |
Adds package exclusions, currently broader than Alpine images. |
CONTRIBUTING.md |
Documents the intended Alpine license exception. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| # Alpine base image, are never linked into or redistributed with gh-aw, and are | ||
| # therefore accepted as a documented policy exception. The allowlist above still | ||
| # applies to every other package in those images. | ||
| ignore-packages: |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily container image scan reported 12 license policy violations for
grafana/mcp-grafana:1.0.0-alpine. All 12 are Alpine base-image OS packages (GPL-2.0-only / MPL-2.0 / Zlib), which cannot be changed without replacing the upstream image.Changes
.grant.yaml— adds anignore-packageslist covering the Alpine base layer (busybox,busybox-binsh,apk-tools,libapk,alpine-baselayout,alpine-baselayout-data,musl-utils,scanelf,ssl_client,ca-certificates,ca-certificates-bundle,zlib), with a comment stating the rationale. The exception is by explicit package name rather than by license or glob, so the MIT/Apache-2.0/BSD/ISC allowlist still governs every other package in every scanned image.CONTRIBUTING.md— a "Container Base OS Packages" subsection under the dependency license policy, so the exception is discoverable from the doc that.grant.yamlreferences.Scanning with the pinned scanner (
anchore/grant:v0.6.8) against the pinned digest goes fromnoncompliant(12 denied, 0 ignored) tocompliant(0 denied, 12 ignored). Note this applies repo-wide, sonode:lts-alpineand any future Alpine-based image get the same treatment — which is the intent.Not addressed: the 2 High vulnerabilities
google.golang.org/grpc(GHSA-hrxh-6v49-42gf) andgolang.org/x/text(GO-2026-5970) are compiled into the upstream binary. The newest published release (v1.1.0) and upstreammainboth still pingrpc v1.80.0andgolang.org/x/text v0.37.0, so a tag bump would not remediate them:These need an upstream dependency bump and release; the daily
compile --force-refresh-container-pinsrun will pick up a fixed image once one exists. An alternative to consider if we want these gone sooner is moving the component off the vendor image entirely — worth weighing separately from this policy change.