Skip to content

Allow repository_dispatch user rate limits - #52101

Merged
pelikhan merged 2 commits into
mainfrom
copilot/deep-report-add-repository-dispatch-to-schema
Aug 11, 2026
Merged

Allow repository_dispatch user rate limits#52101
pelikhan merged 2 commits into
mainfrom
copilot/deep-report-add-repository-dispatch-to-schema

Conversation

Copilot AI commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

user-rate-limit.events rejected repository_dispatch despite the compiler treating it as an inferred programmatic trigger. This aligns explicit configuration with compiler behavior.

  • Schema

    • Add repository_dispatch to the allowed user-rate-limit.events enum.
  • Regression coverage

    • Validate a repository_dispatch workflow with explicit rate-limit configuration.
on: repository_dispatch
user-rate-limit:
  max-runs-per-window: 1
  events: [repository_dispatch]

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add missing repository_dispatch to user-rate-limit.events schema Allow repository_dispatch user rate limits Aug 11, 2026
Copilot AI requested a review from pelikhan August 11, 2026 15:45
@pelikhan
pelikhan marked this pull request as ready for review August 11, 2026 15:46
Copilot AI balanced review requested due to automatic review settings August 11, 2026 15:46
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

No new or modified test functions detected in PR #52101. pkg/parser/schema_test.go appears in the changed files list but the test diff is empty — no func Test* additions or modifications were extracted. Test Quality Sentinel skipped.

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (15 additions detected).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • api.individual.githubcopilot.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.individual.githubcopilot.com"

See Network Configuration for more information.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #52101

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns explicit user-rate-limit.events validation with compiler inference for repository_dispatch.

Changes:

  • Adds repository_dispatch to the schema enum.
  • Adds regression coverage for explicit configuration.
Show a summary per file
File Description
pkg/parser/schemas/main_workflow_schema.json Allows repository_dispatch rate limits.
pkg/parser/schema_test.go Verifies schema acceptance.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /tdd — the PR ships a regression test alongside the fix. Approving.

📋 Summary

Positive Highlights

  • ✅ Schema enum addition is minimal and precisely targeted
  • ✅ Regression test mirrors the exact YAML from the issue description
  • ✅ Test name clearly documents the expected behaviour
  • ✅ No unrelated changes

Minor observations (non-blocking)

  • The test only exercises the happy path. A complementary negative test (e.g. an unknown event value is rejected) would strengthen the schema contract, but is not required for this fix.
  • The description field in the schema still lists example events (workflow_dispatch, issue_comment, pull_request_review) but omits repository_dispatch; a docs-only follow-up could align the prose with the enum.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 18.2 AIC · ⌖ 6.47 AIC · ⊞ 7.1K
Comment /matt to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — small, well-scoped schema addition with a matching test. repository_dispatch is a programmatic trigger consistent with the other events already listed in the enum.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 11.6 AIC · ⌖ 6.16 AIC · ⊞ 5.4K

@pelikhan
pelikhan merged commit 3b250f0 into main Aug 11, 2026
89 of 98 checks passed
@pelikhan
pelikhan deleted the copilot/deep-report-add-repository-dispatch-to-schema branch August 11, 2026 16:57
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.86.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-report] Add missing repository_dispatch to user-rate-limit.events schema enum

3 participants