Allow repository_dispatch user rate limits - #52101
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Test Quality Sentinel completed test quality analysis. No new or modified test functions detected in PR #52101. pkg/parser/schema_test.go appears in the changed files list but the test diff is empty — no func Test* additions or modifications were extracted. Test Quality Sentinel skipped.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (15 additions detected).
|
|
✅ PR Code Quality Reviewer completed the code quality review. Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "api.individual.githubcopilot.com"See Network Configuration for more information.
|
|
✅ Ponytail Reviewer completed successfully! Lean already. Ship.
|
There was a problem hiding this comment.
Pull request overview
Aligns explicit user-rate-limit.events validation with compiler inference for repository_dispatch.
Changes:
- Adds
repository_dispatchto the schema enum. - Adds regression coverage for explicit configuration.
Show a summary per file
| File | Description |
|---|---|
pkg/parser/schemas/main_workflow_schema.json |
Allows repository_dispatch rate limits. |
pkg/parser/schema_test.go |
Verifies schema acceptance. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /tdd — the PR ships a regression test alongside the fix. Approving.
📋 Summary
Positive Highlights
- ✅ Schema enum addition is minimal and precisely targeted
- ✅ Regression test mirrors the exact YAML from the issue description
- ✅ Test name clearly documents the expected behaviour
- ✅ No unrelated changes
Minor observations (non-blocking)
- The test only exercises the happy path. A complementary negative test (e.g. an unknown event value is rejected) would strengthen the schema contract, but is not required for this fix.
- The
descriptionfield in the schema still lists example events (workflow_dispatch,issue_comment,pull_request_review) but omitsrepository_dispatch; a docs-only follow-up could align the prose with the enum.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 18.2 AIC · ⌖ 6.47 AIC · ⊞ 7.1K
Comment /matt to run again
There was a problem hiding this comment.
LGTM — small, well-scoped schema addition with a matching test. repository_dispatch is a programmatic trigger consistent with the other events already listed in the enum.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 11.6 AIC · ⌖ 6.16 AIC · ⊞ 5.4K
|
🎉 This pull request is included in a new release. Release: |
user-rate-limit.eventsrejectedrepository_dispatchdespite the compiler treating it as an inferred programmatic trigger. This aligns explicit configuration with compiler behavior.Schema
repository_dispatchto the alloweduser-rate-limit.eventsenum.Regression coverage
repository_dispatchworkflow with explicit rate-limit configuration.repository_dispatchtouser-rate-limit.eventsschema enum #52087