Skip to content

Suppress visual regression loopback Runner-Guard finding #51947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Aug 11, 2026
Merged

Suppress visual regression loopback Runner-Guard finding #51947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07db0f9
Initial plan
Copilot Aug 11, 2026
7997ee5
Suppress visual regression loopback runner-guard finding
Copilot Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 2 additions & 31 deletions .github/workflows/visual-regression-checker.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .github/workflows/visual-regression-checker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ steps:
run: |
MAX_WAIT=90
WAITED=0
# runner-guard:ignore RGS-012 -- loopback-only port probe for the docs server started in this job; no external network or secret data is involved.
until (echo > /dev/tcp/127.0.0.1/4321) > /dev/null 2>&1; do
if [ -f /tmp/gh-aw/agent/server.pid ] && ! kill -0 "$(cat /tmp/gh-aw/agent/server.pid)" 2>/dev/null; then
echo "Docs server process exited before opening port 4321" >&2
Expand All @@ -88,6 +89,7 @@ steps:
sleep 3
done
WAITED=0
# runner-guard:ignore RGS-012 -- localhost readiness request to the docs server started above; response is discarded and no secrets are sent.
until curl -sf http://localhost:4321/gh-aw/ > /dev/null 2>&1; do
WAITED=$((WAITED + 3))
if [ $WAITED -ge $MAX_WAIT ]; then
Expand Down