Skip to content

Fix responsive docs navigation test targeting #51540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Aug 9, 2026
Merged

Fix responsive docs navigation test targeting #51540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aac562
Initial plan
Copilot Aug 9, 2026
490d553
Fix responsive docs navigation testing
Copilot Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/daily-multi-device-docs-tester.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions .github/workflows/daily-multi-device-docs-tester.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,11 @@ For each device viewport, use playwright-cli to:
- Test interactions (navigation, search, buttons)
- Check for layout issues (overflow, truncation, broken layouts)

For mobile and tablet viewports (width ≤1050px), test the responsive header navigation explicitly:
- Click `.hamburger-btn` and verify its `aria-expanded` attribute is `true`.
- Target a visible `.tablet-dropdown .dropdown-link[href$="setup/quick-start/"]:visible` rather than a generic `nav a[href]`, which can select the hidden desktop navigation.
- Click the visible link and verify that it navigates to its expected URL.

## Step 4: Analyze Results

Organize findings by severity:
Expand Down
23 changes: 23 additions & 0 deletions docs/tests/mobile-responsive.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,29 @@ test.describe('Mobile and Responsive Layout', () => {
await expect(page.locator('#main-content')).toHaveCount(1);
});

for (const viewport of [
{ name: 'mobile', width: 390, height: 844 },
{ name: 'tablet', width: 768, height: 1024 },
{ name: 'large tablet', width: 834, height: 1194 },
{ name: 'tablet landscape', width: 1024, height: 768 },
]) {
test(`should navigate through the responsive header menu on ${viewport.name}`, async ({ page }) => {
await page.setViewportSize(viewport);
await page.goto('/gh-aw/');
await page.waitForLoadState('networkidle');

const menuButton = page.locator('.hamburger-btn');
await expect(menuButton).toBeVisible();
await menuButton.click();
await expect(menuButton).toHaveAttribute('aria-expanded', 'true');

const quickStartLink = page.locator('.tablet-dropdown .dropdown-link[href$="setup/quick-start/"]:visible');
await expect(quickStartLink).toBeVisible();
await quickStartLink.click();
await expect(page).toHaveURL(/\/gh-aw\/setup\/quick-start\/$/);
});
}

for (const formFactor of formFactors) {
test.describe(`${formFactor.name}`, () => {
test.beforeEach(async ({ page }) => {
Expand Down