fix(seenmapbool): treat non-true values in declaration-site composite literals as non-set maps

[Copilot]

seenmapbool decided whether a map[string]bool was a pure true-sentinel set by scanning only for later m[k] = v statements, never inspecting the composite literal supplied at the declaration. A map populated in one shot with mixed values was therefore misflagged, suggesting a map[string]struct{} conversion that would drop real false entries.

func BadCompositeLiteralMixedValues() {
	flags := map[string]bool{"enabled": true, "disabled": false} // previously flagged as "used as a set"
	_ = flags
}

Changes

• findNonSetMaps now also visits initializers, not just IndexExpr assignments:
  • *ast.ValueSpec values, covering the var flags = map[string]bool{...} branch.
  • *ast.AssignStmt RHS when the LHS is a plain identifier, covering the := branch.
• New markIfNonSetLiteral helper — for a candidate whose initializer is an *ast.CompositeLit, marks it non-set if any KeyValueExpr.Value fails isBoolTrue, mirroring how a later m[k] = false is handled.
• Initializers that are not composite literals (make(...), calls, map copies) return early, so existing candidate collection and diagnostics are untouched.

Tests

Added two testdata cases expecting no diagnostic: GoodBoolMapLiteralWithFalse (:= form) and GoodBoolMapVarLiteralWithFalse (var form). Existing BadSetBool*, GoodBoolMapWithFalse, closure, and //nolint cases are unchanged.

• Fixes seenmapbool: composite-literal initial values are never checked, so a map with a real false entry is misflagged as a pure set #51510

[github-actions]

Great work on this fix! 🎯 This PR correctly addresses the issue where the seenmapbool linter was misflagging map[string]bool composite literals with mixed boolean values. The changes are focused, well-tested with both := and var forms covered, and the description clearly explains the bug and solution. The implementation properly mirrors existing false-detection logic at the initialization site, and test coverage ensures both good and bad cases are caught. Ready for review!

Generated by ✅ Contribution Check · auto · 80.4 AIC · ⌖ 4.92 AIC · ⊞ 8.8K · ◷

[github-actions]

PR Triage

• Category: bug
• Risk: low
• Priority: low
• Score: 31/100 (impact 15 + urgency 8 + quality 8)
• Recommended action: defer

Small draft lint-tool fix, low urgency, still in progress.

Generated by 🔧 PR Triage Agent · auto · 58.3 AIC · ⌖ 2.48 AIC · ⊞ 8K · ◷

[Copilot]

Pull request overview

Fixes seenmapbool false positives for maps initialized with meaningful false values.

Changes:

• Inspects var and assignment initializers.
• Marks mixed-value composite literals as non-set maps.
• Adds regression cases for := and var declarations.

Show a summary per file

File	Description
pkg/linters/seenmapbool/seenmapbool.go	Adds declaration-site literal analysis.
pkg/linters/seenmapbool/testdata/src/seenmapbool/seenmapbool.go	Adds mixed-value literal test cases.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Balanced

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.86.2