Skip to content

[WIP] Fix artifact check to prevent run failure on missing session logs - #50397

Merged
pelikhan merged 2 commits into
mainfrom
copilot/aw-failures-fix-copilot-session-data
Aug 4, 2026
Merged

pelikhan merged 2 commits into
mainfrom
copilot/aw-failures-fix-copilot-session-data

Conversation

Copilot AI commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor
  • Inspect the failed Copilot Session Insights run and workflow guidance
  • Locate the session-artifact fetch and existing validation coverage
  • Make missing per-session logs non-fatal while preserving useful reporting
  • Recompile the workflow and run focused validation
  • Perform security/review validation and publish the final change

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review August 4, 2026 21:18
Copilot AI balanced review requested due to automatic review settings August 4, 2026 21:18
@pelikhan
pelikhan merged commit b06fc8f into main Aug 4, 2026
@pelikhan
pelikhan deleted the copilot/aw-failures-fix-copilot-session-data branch August 4, 2026 21:18
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Thanks for tackling this workflow stability issue @Copilot 👋 — this looks well-focused and directly addresses issue #50273. Here's the current status:

What looks good:

  • ✅ Changes are minimal and focused (15 lines across 3 files)
  • ✅ Clear mapping to the issue: converts hard-fail error to graceful warning when session artifacts are missing
  • ✅ Documentation in the markdown file explains the behavior change well
  • ✅ Properly marked as [WIP] with a clear checklist

Before merging:

  • This is still in draft—the checklist shows one pending item: "Perform security/review validation and publish the final change."
  • Consider adding validation or test coverage for the workflow logic change.
  • Once security review is complete and the WIP status is removed, this should be ready for merge.

The change itself is solid—graceful degradation is the right approach here!

Generated by ✅ Contribution Check · auto · 66.9 AIC · ⌖ 4.03 AIC · ⊞ 8.8K · ◷

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes missing Copilot session logs non-fatal while retaining warning-based visibility.

Changes:

  • Downgrades missing-log errors to warnings.
  • Removes the aggregate failure exit.
  • Recompiles both consuming workflows.
Show a summary per file
File Description
.github/workflows/shared/copilot-session-data-fetch.md Implements graceful degradation and updates documentation.
.github/workflows/copilot-session-insights.lock.yml Regenerates Session Insights with the new behavior.
.github/workflows/copilot-opt.lock.yml Regenerates Copilot Opt with the new behavior.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.85.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw-failures] Copilot Session Insights: all-or-nothing artifact check fails whole run when any sampled session log is missing

3 participants