Skip to content

Pin poutine Docker image to the digest-pinned constant #50279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Aug 4, 2026
Merged

Pin poutine Docker image to the digest-pinned constant #50279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffbaa4b
Initial plan
Copilot Aug 4, 2026
719f418
Pin poutine docker image to digest-pinned constant
Copilot Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/cli/poutine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func runPoutineOnDirectory(workflowDir string, verbose bool, strict bool) error
}

// Build the Docker command with JSON output for easier parsing
// docker run --rm -v "$(pwd)":/workdir -w /workdir ghcr.io/boostsecurityio/poutine:latest analyze_local . --format json
// docker run --rm -v "$(pwd)":/workdir -w /workdir <PoutineImage> analyze_local . --format json
// #nosec G204 -- gitRoot comes from git rev-parse (trusted source) and is validated as absolute path
// exec.Command with separate args (not shell execution) prevents command injection
volumeMount, err := buildDockerVolumeMount(gitRoot, "/workdir")
Expand All @@ -112,7 +112,7 @@ func runPoutineOnDirectory(workflowDir string, verbose bool, strict bool) error
"--rm",
"-v", volumeMount,
"-w", "/workdir",
"ghcr.io/boostsecurityio/poutine:latest",
PoutineImage,
"analyze_local",
".",
"--format", "json",
Expand All @@ -130,7 +130,7 @@ func runPoutineOnDirectory(workflowDir string, verbose bool, strict bool) error
"--rm",
"-v", volumeMount,
"-w", "/workdir",
"ghcr.io/boostsecurityio/poutine:latest",
PoutineImage,
"analyze_local",
".",
"--format", "json",
Expand Down Expand Up @@ -215,7 +215,7 @@ func runPoutineOnFile(lockFile string, verbose bool, strict bool) error {
}

// Build the Docker command with JSON output for easier parsing
// docker run --rm -v "$(pwd)":/workdir -w /workdir ghcr.io/boostsecurityio/poutine:latest analyze_local . --format json
// docker run --rm -v "$(pwd)":/workdir -w /workdir <PoutineImage> analyze_local . --format json
// #nosec G204 -- gitRoot comes from git rev-parse (trusted source) and is validated as absolute path
// exec.Command with separate args (not shell execution) prevents command injection
volumeMount, err := buildDockerVolumeMount(gitRoot, "/workdir")
Expand All @@ -232,7 +232,7 @@ func runPoutineOnFile(lockFile string, verbose bool, strict bool) error {
"--rm",
"-v", volumeMount,
"-w", "/workdir",
"ghcr.io/boostsecurityio/poutine:latest",
PoutineImage,
"analyze_local",
".",
"--format", "json",
Expand All @@ -250,7 +250,7 @@ func runPoutineOnFile(lockFile string, verbose bool, strict bool) error {
"--rm",
"-v", volumeMount,
"-w", "/workdir",
"ghcr.io/boostsecurityio/poutine:latest",
PoutineImage,
"analyze_local",
".",
"--format", "json",
Expand Down
9 changes: 9 additions & 0 deletions pkg/cli/poutine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,3 +360,12 @@ func TestEnsurePoutineConfig(t *testing.T) {
}
})
}

func TestPoutineImageIsPinnedByDigest(t *testing.T) {
if _, err := validateDockerImageRef(PoutineImage); err != nil {
t.Fatalf("PoutineImage %q failed docker image reference validation: %v", PoutineImage, err)
}
if !strings.Contains(PoutineImage, "@sha256:") {
Comment on lines +364 to +368
t.Errorf("PoutineImage must be pinned by digest, got %q", PoutineImage)
}
}
Loading