Conservatively treat computed shell options as shell-enabled in child_process command rule

eslint-factory/src/rules/no-child-process-interpolated-command.test.ts

@@ -19,6 +19,7 @@ describe("no-child-process-interpolated-command", () => {
         { code: `const { spawn } = require("child_process"); spawn(\`git \${branch}\`, ["status"]);` },
         { code: `const { spawnSync } = require("child_process"); const cmd = \`git checkout \${branch}\`; spawnSync(cmd);` },
         { code: `const { execFileSync } = require("child_process"); execFileSync("git", ["status"], { shell: false });` },
+        { code: `const { spawn } = require("child_process"); spawn(\`git checkout \${branch}\`, { shell: undefined });` },
         { code: `const { execSync } = require("child_process"); const cmd = "git status"; execSync(cmd);` },
         { code: `const { execSync } = require("child_process"); let cmd = \`git checkout \${branch}\`; cmd = "git status"; execSync(cmd);` },
         { code: `const { execSync } = require("child_process"); (function(cmd) { execSync(cmd); })("git status");` },
@@ -67,6 +68,18 @@ describe("no-child-process-interpolated-command", () => {
           code: `const { spawn } = require("child_process"); spawn(\`git checkout \${branch}\`, { shell: "/bin/bash" });`,
           errors: [{ messageId: "interpolatedCommand", data: { kind: "interpolated template literal", method: "spawn" } }],
         },
+        {
+          code: `const { spawn } = require("child_process"); const isWindows = process.platform === "win32"; spawn(\`git checkout \${branch}\`, ["status"], { shell: isWindows });`,
+          errors: [{ messageId: "interpolatedCommand", data: { kind: "interpolated template literal", method: "spawn" } }],
+        },
+        {
+          code: `const { spawn } = require("child_process"); spawn("git checkout " + branch, ["status"], { shell: process.platform === "win32" });`,
+          errors: [{ messageId: "interpolatedCommand", data: { kind: "dynamic string concatenation", method: "spawn" } }],
+        },
+        {
+          code: `const { execFileSync } = require("child_process"); const cond = process.platform === "win32"; execFileSync(\`git \${branch}\`, ["status"], { shell: cond ? true : false });`,
+          errors: [{ messageId: "interpolatedCommand", data: { kind: "interpolated template literal", method: "execFileSync" } }],
+        },
         {
           code: `const { spawn } = require("child_process"); const opts = [{ shell: true }]; spawn("git checkout " + branch, ...opts);`,
           errors: [{ messageId: "interpolatedCommand", data: { kind: "dynamic string concatenation", method: "spawn" } }],

eslint-factory/src/rules/no-child-process-interpolated-command.ts

@@ -40,7 +40,11 @@ function getShellPropertyValue(optionsArg: TSESTree.ObjectExpression): boolean {
     const keyName = prop.key.type === AST_NODE_TYPES.Identifier ? prop.key.name : prop.key.type === AST_NODE_TYPES.Literal ? prop.key.value : null;
     if (keyName !== "shell") continue;
 
-    return prop.value.type === AST_NODE_TYPES.Literal && (prop.value.value === true || typeof prop.value.value === "string");
+    if (prop.value.type === AST_NODE_TYPES.Literal) {
+      return prop.value.value === true || typeof prop.value.value === "string";
+    }
+
+    return !(prop.value.type === AST_NODE_TYPES.Identifier && prop.value.name === "undefined");
   }
 
   return false;