Skip to content

fix(conformance): fix WTD-001/WTD-002 false-positives on centralized threat-detection label string #49753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Aug 2, 2026
Merged

fix(conformance): fix WTD-001/WTD-002 false-positives on centralized threat-detection label string #49753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e36949
Initial plan
Copilot Aug 2, 2026
3c610a4
fix(conformance): fix WTD-001/WTD-002 false-positives on centralized …
Copilot Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions scripts/check-safe-outputs-conformance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,7 +1343,20 @@ check_wtd_reviewable_annotation() {
fi

# Check label string "agentic threat detected" (requirement 2)
if ! grep -q "agentic threat detected" "$footer_file"; then
# The footer may delegate to a centralised template (threat_detection_caution.md) or
# to threat_detection_warning.cjs, so accept those as equivalent evidence.
local label_found=0
if grep -q "agentic threat detected" "$footer_file" 2>/dev/null; then
label_found=1
elif grep -q "threat_detection_caution" "$footer_file" 2>/dev/null; then
local caution_template="actions/setup/md/threat_detection_caution.md"
if [ -f "$caution_template" ] && grep -q "agentic threat detected" "$caution_template" 2>/dev/null; then
label_found=1
elif [ -f "$threat_warning_file" ] && grep -q "agentic threat detected" "$threat_warning_file" 2>/dev/null; then
label_found=1
fi
Comment on lines +1353 to +1357
fi
if [ $label_found -eq 0 ]; then
log_critical "WTD-001: Footer generator missing 'agentic threat detected' label string (WTD1 requirement 2)"
failed=1
fi
Expand Down Expand Up @@ -1399,8 +1412,19 @@ check_wtd_convertible_fallback() {
failed=1
fi

# Check that the caution text is emitted in the fallback
if ! grep -q "agentic threat detected" "$push_handler"; then
# Check that the caution text is emitted in the fallback.
# The handler may delegate to threat_detection_warning.cjs via
# getThreatWarningPresentation(), so accept that as equivalent evidence.
local threat_label_found=0
if grep -q "agentic threat detected" "$push_handler" 2>/dev/null; then
threat_label_found=1
elif grep -q "getThreatWarningPresentation" "$push_handler" 2>/dev/null; then
local threat_warning_file="actions/setup/js/threat_detection_warning.cjs"
if [ -f "$threat_warning_file" ] && grep -q "agentic threat detected" "$threat_warning_file" 2>/dev/null; then
Comment on lines +1421 to +1423
threat_label_found=1
fi
fi
if [ $threat_label_found -eq 0 ]; then
log_high "WTD-002: push_to_pull_request_branch fallback missing 'agentic threat detected' text (WTD2 / WTD1)"
failed=1
fi
Expand Down