Use testify assertions in pkg/errorutil/errors_test.go for consistent table-test failures#35776
Merged
pelikhan merged 3 commits intoMay 29, 2026
Merged
Conversation
6 tasks
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve test quality in pkg/errorutil/errors_test.go
Use testify assertions in May 29, 2026
pkg/errorutil/errors_test.go for consistent table-test failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/errorutil/errors_test.goused manualt.Errorfchecks while the same package already uses testify assertions in sibling tests. This PR aligns assertion style acrosserrorutiland improves failure readability in table-driven subtests.Assertion style alignment
github.com/stretchr/testify/assertimport inpkg/errorutil/errors_test.go.if got != tt.want { t.Errorf(...) }) withassert.Equal(...).Scope of updates
TestIsNotFoundErrorTestIsForbiddenErrorTestIsGoneErrortt.name.Representative change