Consolidate workflow FieldLocation onto console ErrorPosition#34123
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Consolidate FieldLocation and ErrorPosition duplicate types
Consolidate workflow May 22, 2026
FieldLocation onto console ErrorPosition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/workflow.FieldLocationandpkg/console.ErrorPositionwere structurally identical (File,Line,Column) and represented the same source-location concept. This PR removes the duplicate definition and makes workflow location handling use the console canonical type.Canonical source-location type
FieldLocationstruct definition inpkg/workflow/workflow_errors.gowith a type alias toconsole.ErrorPosition.Workflow package wiring
pkg/consoleimport inworkflow_errors.goto support the alias.NewValidationErrorWithLocation(..., loc FieldLocation)API shape unchanged for compatibility.Type-level compatibility guard
TestFieldLocationAlias) inpkg/workflow/error_helpers_test.goto assert direct assignability between workflow and console location types.