Add `on.pull_request_reviewer: slash_command` synthetic trigger and reviewer lifecycle routing by Copilot · Pull Request #33273 · github/gh-aw

Copilot · 2026-05-19T10:34:41Z

This introduces a synthetic reviewer trigger to support fill-PR-reviewer lifecycle dispatch through centralized command routing. It adds reviewer-aware concurrency, lifecycle event routing, PR-closed startup cancellation, and marker-based workflow resolution for review events.

Trigger model + schema
- Adds on.pull_request_reviewer to the main workflow schema with slash_command as the supported mode.
- Wires frontmatter extraction and workflow data propagation for reviewer-triggered workflows.
Compiler defaults for reviewer lifecycle
- Treats reviewer trigger as centralized command routing.
- Adds reviewer lifecycle event coverage for pull_request (ready_for_review) and pull_request_review.
- Applies PR-scoped concurrency defaults with queue-max behavior for reviewer flows.
Central router generation (agentic_commands.yml)
- Extends route collection to emit reviewer lifecycle routes.
- Adds reviewer routing payload (GH_AW_REVIEWER_ROUTING) and reviewer section in generated routing metadata/comments.
- Ensures workflow generation remains enabled when reviewer routes exist even without standard slash/label routes.
Runtime dispatch (route_slash_command.cjs)
- Cancels execution early when the PR is already closed at workflow start.
- Dispatches reviewer workflows for pull_request ready_for_review.
- Dispatches reviewer workflows for pull_request_review actions (submitted, edited, dismissed) by resolving the target workflow from XML markers in review body.
Special resolution path for review events
- Uses existing XML marker extraction (extractWorkflowId) to map review/resolution activity back to the correct workflow owner/creator context.

on:
  pull_request_reviewer: slash_command

// reviewer route payload example
GH_AW_REVIEWER_ROUTING='[
  {"workflow":"pr-reviewer","events":["pull_request","pull_request_review"]}
]'

pr-sous-chef: request to update branch (run id: 26122348307)

Generated by 👨‍🍳 PR Sous Chef · ● 246.4K · ◷

Changeset

Type: patch
Description: Add synthetic on.pull_request_reviewer trigger support and reviewer lifecycle routing for pull request review workflows.

Generated by 📋 Changeset Generator for issue #33273 · ● 1.8M · ◷

✨ PR Review Safe Output Test - Run 26125419230

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · ● 7.1M · ◷

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-05-19T10:46:07Z

@copilot

each agentic workflow should have a unique slash command name

on:
pull_request_reviewer: <slash_command_id>

that is compiled as a centralized slash command

register a global "/review" command that dispatches all reviewers on the PR. shortcut on closed PR.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-05-19T10:57:44Z

@copilot slash command id should be inferred if missing

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-05-19T10:59:53Z

@copilot

each agentic workflow should have a unique slash command name...

Implemented in 17789b4: pull_request_reviewer workflows now enforce unique slash command names (case-insensitive) and compilation fails on duplicates. Added coverage in TestGenerateCentralSlashCommandWorkflow_ErrorsOnDuplicateReviewerCommandName.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-05-19T11:08:58Z

@copilot slash command id should be inferred if missing

Implemented in 4bb9817: when a pull_request_reviewer workflow has no slash command configured, the router now infers it from the workflow ID and includes it in centralized slash routing. Uniqueness checks still apply to inferred IDs.

pelikhan · 2026-05-19T13:37:24Z

@copilot

remove slash command automatic generation with reviewer, the user can declare slash-command
handle or review requested to rerun the reviewers

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-05-19T13:48:20Z

@copilot

remove slash command automatic generation with reviewer, the user can declare slash-command ...

Addressed in e348900.

Removed automatic slash-command inference for pull_request_reviewer; reviewer workflows now only route slash commands that are explicitly declared by the user.
Added reviewer rerun handling for pull_request review_requested events in centralized reviewer lifecycle routing.

pelikhan · 2026-05-19T13:56:50Z

@copilot refactor reviewer agentic workflows to use this trigger: ADR, Matt pollock,

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-05-19T14:21:34Z

@copilot refactor reviewer agentic workflows to use this trigger: ADR, Matt pollock,

Updated in 8473865 (follow-up fix f2f8717): mattpocock-skills-reviewer now uses on.pull_request_reviewer: slash_command with an explicit centralized slash command declaration.

Copilot · 2026-05-19T20:48:23Z

@copilot fix test https://github.com/github/gh-aw/actions/runs/26122689755/job/76830209288?pr=33273

Fixed in a15de68: populated CommandOtherEvents with reviewer lifecycle events (pull_request and pull_request_review) for centralized routing. All tests now pass.

@copilot fix test https://github.com/github/gh-aw/actions/runs/26122689755/job/76830209288?pr=33273

Fixed in 974fdba: populated CommandOtherEvents with reviewer lifecycle events (pull_request and pull_request_review) for centralized routing. All tests now pass.

github-actions · 2026-05-19T21:08:49Z

💫 TO BE CONTINUED... Smoke Claude failed! Our hero faces unexpected challenges...

github-actions · 2026-05-19T21:08:50Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-05-19T21:08:52Z

🚀 Smoke Gemini MISSION COMPLETE! Gemini has spoken. ✨

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Details

The threat detection results could not be parsed.

Review the workflow run logs for details.

github-actions · 2026-05-19T21:08:53Z

✅ Smoke OTEL completed successfully!

github-actions · 2026-05-19T21:08:59Z

🚀 Smoke Pi MISSION COMPLETE! Pi delivered. 🥧

github-actions · 2026-05-19T21:09:21Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-05-19T21:12:01Z

Commit pushed: 4fe7148

Generated by Changeset Generator · ● 1.8M

github-actions · 2026-05-19T21:12:41Z

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Details

The threat detection results could not be parsed.

Review the workflow run logs for details.

Smoke test results: FAIL (Build failed). See issue for details.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

✨ Smoke Gemini — Powered by Gemini · ◷

github-actions · 2026-05-19T21:13:16Z

Agent Container Tool Check

Tool	Status	Version
bash	✅	5.2.21
sh	✅	available
git	✅	2.54.0
jq	✅	1.7
yq	✅	4.53.2
curl	✅	8.5.0
gh	✅	2.92.0
node	✅	22.22.2
python3	✅	3.14.5
go	✅	1.24.13
java	✅	21.0.11
dotnet	✅	10.0.300

Result: 12/12 tools available ✅

🔧 Tool validation by Agent Container Smoke Test · ● 1.4M · ◷

github-actions · 2026-05-19T21:16:43Z

Smoke Test Codex 26125419171: FAIL
PRs: #33387 [safe-output-integrator] Add missing safe-output test coverage for set-issue-field and dispatch_repository; #33385 Strengthen timeout_minutes codemod tests with multiple-occurrence coverage
✅ GitHub MCP ✅ Serena ✅ Playwright ❌ Web Fetch ✅ File/Bash ✅ Build ❌ Comment Memory ✅ Cache Memory ⏳ Issue Field
Run: https://github.com/github/gh-aw/actions/runs/26125419171

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex · ● 6.4M · ◷

github-actions · 2026-05-19T21:20:25Z

✅ Smoke Test Complete - 26125419161

Results: 16/17 tests pass (1 tool unavailable)

GitHub MCP ✅
Serena CLI ✅
Playwright ✅
Build ✅

Status: PASS ✅

Caveman approve! @pelikhan @Copilot

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot · ● 5.5M · ◷

github-actions · 2026-05-19T21:20:25Z

🎉 Update from cave: Me still here! Discussion created successful!

Me dance around fire now. Code spirits happy. Test pass like mammoth through valley! 🔥🦣✨

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot · ● 5.5M · ◷

github-actions

✅ Smoke Test PASS - Run 26125419161

GitHub MCP: ✅
MCP Scripts: ✅
Serena CLI: ✅
Playwright: ✅
Build: ✅ (27M binary)
All test: ✅

Caveman happy! @pelikhan @Copilot

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot · ● 5.5M

github-actions · 2026-05-19T21:20:56Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-05-19T21:24:21Z

Smoke Test: Claude — Run 26125419230

Core #1–12: ✅ all pass
PR review #13–18: ✅ all pass
#19 close PR: ⚠️ skipped (no safe test PR)

Overall: ✅ PASS

§26125419230

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · ● 7.1M · ◷

github-actions

💥 Automated smoke test review - all systems nominal!

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · ● 7.1M

github-actions · 2026-05-19T21:24:25Z

    }

+    // add_comment uses snake_case fields. camelCase and kebab-case aliases are
+    // accepted for compatibility with forwarded/legacy payload variants.


Smoke test review: Consider double-checking the discussion_number/pr alias normalization path here. 🤖

github-actions · 2026-05-19T21:24:25Z

+
 type commandsHeaderMetadata struct {
 	PayloadVersion string   `json:"payload_version"`
 	SchemaVersion  string   `json:"schema_version"`


Smoke test review: ensure CommandOtherEvents lifecycle routing covers all reviewer events. 🛡️

Add pull_request_reviewer synthetic trigger lifecycle routing

ec9d834

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan May 19, 2026

Copilot AI changed the title ~~Add pull_request_reviewer synthetic trigger lifecycle routing~~ Add on.pull_request_reviewer: slash_command synthetic trigger and reviewer lifecycle routing May 19, 2026

Copilot created this pull request from a session on behalf of pelikhan May 19, 2026 10:35 View session

Copilot finished work on behalf of pelikhan May 19, 2026 10:35

Copilot AI requested a review from pelikhan May 19, 2026 10:35

Copilot started work on behalf of pelikhan May 19, 2026 10:46 View session

Copilot AI and others added 2 commits May 19, 2026 10:50

Plan reviewer command uniqueness fix

355738b

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Enforce unique slash commands for pull_request_reviewer workflows

17789b4

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Add doc comment for reviewer command uniqueness validator

99877f5

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan May 19, 2026 11:00

Copilot started work on behalf of pelikhan May 19, 2026 11:00 View session

Copilot AI and others added 2 commits May 19, 2026 11:07

Infer reviewer slash command id when missing

4bb9817

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Document reviewer command inference normalization

8a9a801

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan May 19, 2026 11:09

Copilot started work on behalf of pelikhan May 19, 2026 13:41 View session

Adjust reviewer routing for explicit commands and review requests

e348900

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan May 19, 2026 14:00

Copilot started work on behalf of pelikhan May 19, 2026 14:06 View session

Copilot AI and others added 2 commits May 19, 2026 14:17

Switch Matt Pocock reviewer to pull_request_reviewer trigger

8473865

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Fix Matt reviewer slash command event list

f2f8717

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan May 19, 2026 20:54

pelikhan added the smoke label May 19, 2026

github-actions Bot removed the smoke label May 19, 2026

Add changeset for reviewer trigger

4fe7148

github-actions Bot added the needs-review label May 19, 2026

github-actions Bot mentioned this pull request May 19, 2026

Smoke OTEL - 26125419165 #33395

Closed

github-actions Bot added the smoke-copilot label May 19, 2026

github-actions Bot mentioned this pull request May 19, 2026

Smoke Test: Copilot - 26125419161 #33399

Closed

github-actions Bot reviewed May 19, 2026

View reviewed changes

github-actions Bot mentioned this pull request May 19, 2026

Smoke Test: Claude - 26125419230 #33400

Closed

github-actions Bot added the smoke-claude label May 19, 2026

github-actions Bot reviewed May 19, 2026

View reviewed changes

pelikhan merged commit c8f2a1d into main May 19, 2026

pelikhan deleted the copilot/add-synthetic-trigger-pull-request-reviewer branch May 19, 2026 22:13

github-actions Bot mentioned this pull request May 20, 2026

[docs] Update glossary - daily scan #33519

Merged

3 tasks

Conversation

Copilot AI commented May 19, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset

Uh oh!

pelikhan commented May 19, 2026

Uh oh!

pelikhan commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

pelikhan commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

pelikhan commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Agent Container Tool Check

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Smoke Test: Claude — Run 26125419230

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 19, 2026 •

edited by github-actions Bot

Loading

Copilot AI commented May 19, 2026 •

edited

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading