Validate required workflows on workflow_run during compile#33191
Merged
pelikhan merged 7 commits intoMay 19, 2026
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix workflow validation for workflow_run trigger in gh aw compile
Validate required May 19, 2026
workflows on workflow_run during compile
Contributor
There was a problem hiding this comment.
Pull request overview
Moves validation of on.workflow_run.workflows from runtime (GitHub Actions reject) to compile time in gh aw compile, so users get immediate, actionable feedback when the field is missing, empty, or contains only whitespace entries.
Changes:
- Added a
workflowspresence/non-empty check tovalidateWorkflowRunBrancheswith a multi-line error message that includes a YAML fix example. - Introduced helper
hasNonEmptyWorkflowRunWorkflowssupportingstring,[]string, and[]anyshapes. - Added three test cases covering missing, empty list, and whitespace-only
workflows.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/agent_validation.go | Adds required workflows validation and helper; updates function-doc comment and log message. |
| pkg/workflow/workflow_run_validation_test.go | Adds three test cases for missing/empty/whitespace workflows. |
| pkg/workflow/expression_extraction_test.go | Minor gofmt-style reformat of a test case struct literal. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/3 changed files
- Comments generated: 0
github-actions Bot
added a commit
that referenced
this pull request
May 19, 2026
…s: current, ignore-if-missing, and workflow_run.workflows validation Documents user-facing changes from PRs merged in the last 24 hours: - gh aw add / add-wizard now accept arbitrary HTTP(S) URLs and JSON workflow definitions (from #33164) - network.allowed-input opt-in input for caller-extensible reusable workflow allowlists (from #33200) - tools.github.allowed-repos: current macro for repo-scoped MCP guard policies (from #33041) - safe-outputs.github-app.ignore-if-missing flag for graceful App-token skip on fork/missing-secret runs (from #33033) - workflow_run.workflows now required at compile time (from #33191) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh aw compilecurrently allowson.workflow_runwithoutworkflows, producing.lock.ymlfiles that GitHub rejects at runtime (on.workflow_run does not reference any workflows). This change moves that failure to compile-time by enforcingworkflow_run.workflowsas required and non-empty.Compiler validation
workflow_runtrigger validation to fail compilation whenworkflowsis missing, empty, or whitespace-only.workflowsvalidation is now enforced first for invalid trigger definitions.Error quality
Test coverage
workflowsworkflows: []workflowscontaining only whitespace entriesNow this is rejected at compile time unless
workflowsincludes at least one non-empty workflow name.