Add missing errorutil package spec and align dependency sections in package READMEs#32822
Merged
Conversation
4 tasks
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/114571bf-1ebb-4e5c-8ced-d4aadf94d80d Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues found in package specification audit
Add missing May 17, 2026
errorutil package spec and align dependency sections in package READMEs
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a missing package specification README for pkg/errorutil and aligns the dependency lists in the pkg/cli and pkg/parser package READMEs to reflect their actual imports of errorutil.
Changes:
- Add new
pkg/errorutil/README.mddocumenting theIsNotFoundErrorhelper, usage, and design notes. - Add
pkg/errorutilto the dependency lists inpkg/cli/README.mdandpkg/parser/README.md.
Show a summary per file
| File | Description |
|---|---|
| pkg/errorutil/README.md | New package spec describing the IsNotFoundError helper and its design. |
| pkg/cli/README.md | Adds errorutil to the internal dependencies list. |
| pkg/parser/README.md | Adds errorutil to the internal dependencies list. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec audit reported a missing package specification for
pkg/errorutiland dependency-list drift inpkg/cliandpkg/parserspecs. This PR closes those documentation gaps so package specs reflect current imports.Add missing package specification
pkg/errorutil/README.mdwith:IsNotFoundError)Align dependency declarations with actual usage
pkg/cli/README.mddependencies to include:github.com/github/gh-aw/pkg/errorutilpkg/parser/README.mddependencies to include:github.com/github/gh-aw/pkg/errorutilrepoutilandstringutilremain explicitly listed inpkg/cli/README.mdas expected by the audit.Spec/API example added for
errorutil