[jsweep] Clean action_conclusion_otlp.cjs

[github-actions]

jsweep: Clean action_conclusion_otlp.cjs

Context: Pure Node.js module (invoked from post.js and clean.sh)

Changes

• Number() + Number.isFinite() instead of parseInt: More explicit about rejecting NaN and Infinity when parsing GITHUB_AW_OTEL_JOB_START_MS. parseInt('Infinity', 10) returns NaN (falsy, same result), but the new code documents intent clearly via Number.isFinite.
• Reordered logic: spanName/startMs are now computed before the endpoint branch — reads top-to-bottom without jumping.
• Positive-condition-first: Changed if (!endpoints) { ... } else { ... } to if (endpoints) { ... } else { ... } to remove the double-negation cognitive load.

Tests

• Before: 17 tests
• After: 18 tests (+1)
• New test: should pass startMs: undefined when GITHUB_AW_OTEL_JOB_START_MS is Infinity — covers the Number.isFinite guard that parseInt did not explicitly test.

✅ Validation

• Formatting: npm run format:cjs ✓
• Linting: npm run lint:cjs ✓
• Type checking: npm run typecheck ✓
• Tests: npx vitest run action_conclusion_otlp.test.cjs — 18/18 passed ✓

Generated by jsweep - JavaScript Unbloater · ● 10.9M · ◷

• expires on May 13, 2026, 5:04 AM UTC

[Copilot]

Pull request overview

Cleans up action_conclusion_otlp.cjs to make the startMs parsing more explicit and the control flow easier to read, and adds a targeted test to cover the new parsing guard.

Changes:

• Switches GITHUB_AW_OTEL_JOB_START_MS parsing to Number() with a Number.isFinite() guard (rejects NaN / Infinity explicitly).
• Reorders spanName / startMs computation ahead of the endpoint logging branch and flips the branch to a positive check (if (endpoints)).
• Adds a new test case ensuring "Infinity" results in startMs: undefined.

Show a summary per file

File	Description
actions/setup/js/action_conclusion_otlp.cjs	Refactors startMs parsing and slightly restructures endpoint-logging flow for clarity.
actions/setup/js/action_conclusion_otlp.test.cjs	Adds test coverage for the "Infinity" start timestamp case.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0

[github-actions]

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 1.6M

[github-actions]

🧪 Test Quality Sentinel Report

Test Quality Score: 100/100

✅ Excellent test quality

Metric	Value
New/modified tests analyzed	1
✅ Design tests (behavioral contracts)	1 (100%)
⚠️ Implementation tests (low value)	0 (0%)
Tests with error/edge cases	1 (100%)
Duplicate test clusters	0
Test inflation detected	No (8 test lines / 8 prod lines = 1:1)
🚨 Coding-guideline violations	None

---

Test Classification Details

Test	File	Classification	Issues Detected
should pass startMs: undefined when GITHUB_AW_OTEL_JOB_START_MS is Infinity	actions/setup/js/action_conclusion_otlp.test.cjs	✅ Design	None

---

No Flagged Tests

All analyzed tests are classified as design tests with no issues detected.

---

Language Support

Tests analyzed:

• 🟨 JavaScript (*.test.cjs): 1 test (vitest)

---

Verdict

✅ Check passed. 0% of new tests are implementation tests (threshold: 30%).

The new test directly validates the behavioral contract introduced in the production change: when GITHUB_AW_OTEL_JOB_START_MS is set to "Infinity", Number("Infinity") yields a non-finite value, so startMs must be coerced to undefined rather than forwarded to the span. This is a genuine edge-case behavioral test that would catch a regression if the Number.isFinite() guard were removed.

The mock target (sendJobConclusionSpan) is external telemetry I/O — an acceptable mocking target per project guidelines.

📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

• Assert on observable outputs, return values, or state changes
• Cover error paths and boundary conditions
• Would catch a behavioral regression if deleted
• Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

• Assert on internal function calls (mocking internals)
• Only test the happy path with typical inputs
• Break during legitimate refactoring even when behavior is correct
• Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §25653320848

🧪 Test quality analysis by Test Quality Sentinel · ● 4.8M · ◷

[github-actions]

✅ Test Quality Sentinel: 100/100. Test quality is excellent — 0% of new tests are implementation tests (threshold: 30%).