Skip to content

[deep-report] Embed SafeOutputTargetConfig in remaining 11 safe-output configs (still duplicated after 2 prior closures) #56706

Description

@github-actions

Description

11 safe-output config structs in pkg/workflow still hand-copy the Target/TargetRepoSlug/AllowedRepos trio instead of embedding the existing shared type SafeOutputTargetConfig (pkg/workflow/safe_outputs_parser.go:9). 13 other configs already do this correctly via SafeOutputTargetConfig \yaml:",inline"``.

This exact ask was filed and closed twice before (#50881, #31970) without the fix actually landing — verified live today (2026-08-28) via direct grep of pkg/workflow/*.go; the duplication is still present in all 11 files.

Affected files (still manually re-declaring the 3 fields)

create_issue.go:21-22, add_comment.go:18-20, dispatch_workflow.go:17, create_pr_review_comment.go:15, create_agent_session.go:13, update_project.go:28, create_pull_request.go:96, push_to_pull_request_branch.go:24, create_code_scanning_alert.go:18, create_discussion.go:21, comment_memory.go:10-12

Suggested Change

Replace the raw field declarations in each struct with an embedded SafeOutputTargetConfig \yaml:",inline"`, matching the pattern already used in assign_milestone.go:12, hide_comment.go:12`, etc. YAML output shape is unchanged since inline embedding serializes identically.

Expected Impact

Removes ~33 duplicated lines and closes the gap so future fields on SafeOutputTargetConfig propagate to all 24 configs automatically instead of silently missing 11 of them.

Suggested Agent

New Agent / general-purpose code-quality fix — mechanical, low-risk.

Estimated Effort

Quick (1-2 hours per source report; verified via live grep)

Data Source

DeepReport analysis 2026-08-28, source: Typist Go Type Consistency Analysis (discussion #56632), Cluster 1.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • api.anthropic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.anthropic.com"

See Network Configuration for more information.

Generated by 🔬 Deep Report · claude · agent · 236.5 AIC · ⌖ 8.15 AIC · ⊞ 12.4K ·

  • expires on Aug 30, 2026, 1:52 PM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions