Skip to content

dismiss-pull-request-review sample contract contradicts ingestion validation #55177

Description

@dsyme

Summary

The dismiss_pull_request_review tool contract says review_id may be omitted for automatic actor-review selection, and the apply handler supports omission/auto, but safe-output ingestion requires review_id. Samples therefore cannot express the documented automatic-selection path.

Reproduction and observed behavior

A sample with:

review_id: "auto"

replays through MCP, then ingestion rejects it:

dismiss_pull_request_review 'review_id' must be a valid positive integer (got: auto)

Removing review_id, as the tool description instructs, also replays successfully but ingestion rejects it:

dismiss_pull_request_review 'review_id' is required

The apply stage receives no messages and the prepared REQUEST_CHANGES review remains undismissed.

Expected: ingestion should accept omission (and, if intended by the public contract, auto) and pass the message to the apply handler's automatic review lookup.

Tested against github/gh-aw main commit eaca36f in source mode with --use-samples.

Parent: https://github.com/githubnext/gh-aw-test/actions/runs/32615153966
Child: https://github.com/githubnext/gh-aw-test/actions/runs/32616136031

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions