[eslint-monster] actions/setup/js error-safety and observability lint slice

[github-actions]

Summary

Daily npm run lint:setup-js surfaced a broad error-safety and observability slice across actions/setup/js. This group clusters findings where runtime failures are swallowed, surfaced unsafely, or lose important context.

Affected files

• actions/setup/js/check_daily_aic_workflow_guardrail.cjs
• actions/setup/js/collect_ndjson_output.cjs
• actions/setup/js/emit_outcome_spans.cjs
• actions/setup/js/extra_empty_commit.cjs
• actions/setup/js/frontmatter_hash_pure.cjs
• actions/setup/js/gateway_difc_filtered.cjs
• actions/setup/js/generate_git_bundle.cjs
• actions/setup/js/generate_git_patch.cjs
• actions/setup/js/generate_observability_summary.cjs
• actions/setup/js/handle_agent_failure.cjs
• actions/setup/js/mcp_dependencies_manager.cjs
• actions/setup/js/parse_custom_log.cjs
• actions/setup/js/parse_gemini_log.cjs
• actions/setup/js/parse_mcp_gateway_log.cjs
• actions/setup/js/parse_pi_log.cjs
• actions/setup/js/parse_threat_detection_results.cjs
• actions/setup/js/push_experiment_state.cjs
• actions/setup/js/push_signed_commits.cjs
• actions/setup/js/push_to_pull_request_branch.cjs
• actions/setup/js/redact_secrets.cjs
• actions/setup/js/render_evals_summary.cjs
• actions/setup/js/run_operation_update_upgrade.cjs
• actions/setup/js/safe_output_type_validator.cjs
• actions/setup/js/safeoutputs_cli.cjs
• actions/setup/js/send_otlp_span.cjs
• actions/setup/js/setup_threat_detection.cjs
• actions/setup/js/start_mcp_gateway.cjs
• actions/setup/js/check_permissions_utils.cjs
• actions/setup/js/checkout_manifest.cjs
• actions/setup/js/complete_pre_created_check_run.cjs
• actions/setup/js/copilot_harness.cjs
• actions/setup/js/copilot_sdk_driver.cjs
• actions/setup/js/create_issue.cjs
• actions/setup/js/detect_agent_errors.cjs
• actions/setup/js/dismiss_pull_request_review.cjs
• actions/setup/js/frontmatter_hash_pure.cjs
• actions/setup/js/mcp_server_core.cjs
• actions/setup/js/parse_mcp_scripts_logs.cjs
• actions/setup/js/parse_token_usage.cjs
• actions/setup/js/pi_agent_core_driver.cjs
• actions/setup/js/pick_experiment.cjs
• actions/setup/js/remove_trigger_label.cjs
• actions/setup/js/resolve_mentions_from_payload.cjs

Representative diagnostics

• check_daily_aic_workflow_guardrail.cjs:118 — gh-aw-custom/no-empty-catch-block
• collect_ndjson_output.cjs:448 — gh-aw-custom/no-empty-catch-block
• check_permissions_utils.cjs:210 — gh-aw-custom/no-unsafe-catch-error-property
• complete_pre_created_check_run.cjs:57 — gh-aw-custom/prefer-get-error-message
• copilot_harness.cjs:937 — gh-aw-custom/no-caught-error-interpolation
• copilot_sdk_driver.cjs:148 — gh-aw-custom/no-err-stack-then-string-fallback

Expected outcome

Replace silent catch blocks with explicit fallback/logging, route caught-error formatting through the shared helpers, and remove unsafe direct property access on unknown thrown values so actions/setup/js error paths become lint-clean without changing behavior.

Remediation checklist

• Keep changes scoped to actions/setup/js error-handling and observability paths only.
• Replace empty catch blocks with explicit logging, fallback handling, or a documented intentional ignore.
• Use safe error formatting helpers such as getErrorMessage(...) instead of direct interpolation, .stack fallbacks, or unsafe .status / .code / .message property reads.
• Preserve current control flow and failure semantics.
• Run npm run lint:setup-js as the final validation.

Copilot instructions

1. Tackle the listed files only.
2. Favor small, mechanical fixes grouped by repeated lint rule.
3. Reuse existing helper patterns already present under actions/setup/js.
4. Do not mix in unrelated refactors.

Generated by 🧹 ESLint Monster · gpt54 · 17 AIC · ⌖ 6.58 AIC · ⊞ 5.5K · ◷

• expires on Aug 28, 2026, 2:03 PM UTC-08:00

[github-actions]

🍪 Issue Monster selected this for Copilot

I've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

Om nom nom! 🍪

🍪 Om nom nom by Issue Monster · gpt54 · 2.71 AIC · ⌖ 10.7 AIC · ⊞ 9.4K · ◷