Skip to content

[deep-report] Split remaining 3 oversized test files left over from #53788 (threat_detection_test.go, copilot_engine_test.go, maintenance_work #54106

Description

@github-actions

Description

Issue #53788 ("Split oversized test files") was closed completed on 2026-08-19 after PR #53818 split pkg/workflow/compiler_jobs_test.go (4,511 → now 567 lines) — but that issue originally named 5 oversized files, and only the largest one was actually split before the issue was closed. Verified live (wc -l) that the other 3 named files are still oversized: pkg/workflow/threat_detection_test.go (3,420 lines), pkg/workflow/copilot_engine_test.go (3,311 lines), and pkg/workflow/maintenance_workflow_test.go (3,076 lines) — all still 4-6x the repo's own 500-800 line file-size convention (developer-code-organization skill). Today's Daily Code Metrics Report (#54071) independently reconfirms all 3 as being among the 10 largest files in the repo and flags "Code Organization" as the weakest component of its quality score (2.5/25).

Expected Impact

Completes the refactor that #53788 started but didn't finish — reduces merge-conflict risk on 3 more high-traffic test files and speeds up editor/LSP responsiveness, following the same precedent (split by functional area: threat category, engine behavior, workflow-maintenance concern) already proven out on compiler_jobs_test.go and frontmatter.go.

Suggested Agent

New Agent (or general refactoring agent), modeled directly on PR #53818's split of compiler_jobs_test.go.

Estimated Effort

Medium (1-4 hours) per file — 3 files remaining.

Data Source

DeepReport Intelligence Briefing analysis of discussion #54071 (Daily Code Metrics Report, 2026-08-19), cross-checked against the closed #53788 and live wc -l verification of current file sizes.

Generated by 🔬 Deep Report · agent · 174.7 AIC · ⌖ 10.9 AIC · ⊞ 11.9K ·

  • expires on Aug 21, 2026, 4:40 PM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions