Skip to content

[step-names] Align step names in daily-model-inventory and safe-outputs custom scripts with glossary/consistency #53903

Description

@github-actions

Step Name Alignment Issues

Analyzed 566 unique step names across all 286 .github/workflows/*.lock.yml files (via yq step-name frequency extraction, since the pre-built manifest at /tmp/gh-aw/agent/step-alignment-input.json exceeded the file-read size limit for this run). Found 2 verified issues, both confirmed against source .md/.go files.


1. Priority: High — "Copilot CLI"/"Copilot SDK" missing "GitHub" prefix

Location: .github/workflows/daily-model-inventory.md (lines 268, 276, 307), compiled into .github/workflows/daily-model-inventory.lock.yml

Current step names:

  • Install Copilot SDK with bundled Copilot CLI
  • Fetch Copilot SDK model billing information
  • Upload Copilot SDK models artifact

Why it conflicts: Every other occurrence in the codebase uses the full glossary term. Install GitHub Copilot CLI appears 449 times and Install GitHub Copilot SDK (Node.js) appears 116 times across other workflows (e.g. Execute GitHub Copilot CLI, 359 times). The glossary is explicit that "GitHub Copilot CLI" (not "Copilot CLI" or "GH Copilot") is the canonical name. These three steps are the only occurrences in the entire codebase that drop the "GitHub" prefix, creating a one-off inconsistency.

Suggested replacement names:

  • Install GitHub Copilot SDK with bundled GitHub Copilot CLI
  • Fetch GitHub Copilot SDK model billing information
  • Upload GitHub Copilot SDK models artifact

2. Priority: Medium — "Safe Outputs Custom Scripts" doesn't match either glossary term it references

Location: pkg/workflow/compiler_safe_outputs_steps.go:314 (hardcoded step name), compiled into any workflow using safe-outputs.scripts: (e.g. smoke-claude.lock.yml)

Current step name: Configure Safe Outputs Custom Scripts

Why it conflicts: The glossary defines two distinct, differently-named concepts:

  • Custom Safe Outputs (safe-outputs.jobs:) — separate GitHub Actions jobs per tool call
  • Safe Output Scripts (safe-outputs.scripts:) — lightweight inline JS handlers (singular "Output", not "Outputs")

This step configures safe-outputs.scripts: (per the surrounding code), so it should use the "Safe Output Scripts" term. Instead it says "Safe Outputs Custom Scripts" — reversed word order and pluralized "Outputs" — which reads as if it relates to "Custom Safe Outputs" (a different feature), risking confusion for anyone debugging workflow logs.

Suggested replacement name: Configure Safe Output Scripts (matches the glossary term exactly and the established Configure <component> pattern used elsewhere, e.g. Configure Git credentials, Configure GH_HOST for enterprise compatibility).


AI dictionary alignment summary

  • Terms reviewed: GitHub Copilot CLI, GitHub Copilot SDK, Safe Output Scripts, Custom Safe Outputs (project glossary only — no generic AI-coding dictionary terms were implicated in this run's findings).
  • Terms adopted: none new; existing glossary terms are correct as defined.
  • Conflicts resolved: none between the two terminology sources; the mismatches found were between step-name text and the existing project glossary, not between the glossary and the AI Coding Dictionary.

Generated by 📋 Step Name Alignment · agent · 95.9 AIC · ⌖ 2.42 AIC · ⊞ 9.8K ·

  • expires on Aug 20, 2026, 8:11 PM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions