Decompose compiler_safe_outputs_job.go — prior fix issue auto-expired unfixed, exact same 144-line function rediscovered
Description: Issue #50515 (filed 2026-08-05, from a compiler-quality report) asked to split buildJobLevelSafeOutputEnvVars (144 lines) out of pkg/workflow/compiler_safe_outputs_job.go and shrink the file below 800 lines. That issue auto-expired on 2026-08-06 with state_reason: not_planned — its only timeline cross-references are two unrelated issues (#50560, #50576), i.e. it was never actually worked. Today's Daily Compiler Code Quality Report - 2026-08-18 independently re-flagged the identical problem: the file is still 1065 lines, and buildJobLevelSafeOutputEnvVars (now at pkg/workflow/compiler_safe_outputs_job.go:761) is still 144 lines, scoring 74/100 ("Acceptable") — the lowest of the three compiler files analyzed. The report also notes the file has few explicit fmt.Errorf/%w wraps relative to its size, risking swallowed error context.
Expected Impact: Splitting the file (e.g. extracting env-var construction into compiler_safe_outputs_envvars.go, per the original suggestion) reduces the file below the 800-line guideline, makes the largest function reviewable, and prevents this from silently re-expiring a second time.
Suggested Agent: General-purpose coding agent / whoever normally handles lint-monster / compiler-quality-driven refactors.
Estimated Effort: Medium (1-4 hours) — mechanical extraction, make test-unit must stay green.
Data Source: DeepReport analysis, 2026-08-18 06:23Z cycle (window since 2026-08-18T00:31Z). Source discussion: #53563. Prior unfixed issue: #50515.
Generated by 🔬 Deep Report · agent · 139.4 AIC · ⌖ 12 AIC · ⊞ 11.9K · ◷
Decompose
compiler_safe_outputs_job.go— prior fix issue auto-expired unfixed, exact same 144-line function rediscoveredDescription: Issue #50515 (filed 2026-08-05, from a compiler-quality report) asked to split
buildJobLevelSafeOutputEnvVars(144 lines) out ofpkg/workflow/compiler_safe_outputs_job.goand shrink the file below 800 lines. That issue auto-expired on 2026-08-06 withstate_reason: not_planned— its only timeline cross-references are two unrelated issues (#50560, #50576), i.e. it was never actually worked. Today's Daily Compiler Code Quality Report - 2026-08-18 independently re-flagged the identical problem: the file is still 1065 lines, andbuildJobLevelSafeOutputEnvVars(now atpkg/workflow/compiler_safe_outputs_job.go:761) is still 144 lines, scoring 74/100 ("Acceptable") — the lowest of the three compiler files analyzed. The report also notes the file has few explicitfmt.Errorf/%wwraps relative to its size, risking swallowed error context.Expected Impact: Splitting the file (e.g. extracting env-var construction into
compiler_safe_outputs_envvars.go, per the original suggestion) reduces the file below the 800-line guideline, makes the largest function reviewable, and prevents this from silently re-expiring a second time.Suggested Agent: General-purpose coding agent / whoever normally handles lint-monster / compiler-quality-driven refactors.
Estimated Effort: Medium (1-4 hours) — mechanical extraction,
make test-unitmust stay green.Data Source: DeepReport analysis, 2026-08-18 06:23Z cycle (window since 2026-08-18T00:31Z). Source discussion: #53563. Prior unfixed issue: #50515.