Skip to content

[deep-report] MCPFailureSummary hand-copies fields instead of embedding AggregatedSummaryBase #52517

Description

@github-actions

Description

pkg/cli/logs_models.go:186-193 defines MCPFailureSummary with Count, Workflows, WorkflowsDisplay, and RunIDs fields hand-copied byte-for-byte from AggregatedSummaryBase (logs_models.go:168-178), which MissingToolSummary and MissingDataSummary already embed. The doc comment on AggregatedSummaryBase even explicitly acknowledges the duplication ("...and as a subset in MCPFailureSummary") but the struct was never refactored to embed it, leaving copy-paste drift risk (e.g. a future field added to AggregatedSummaryBase won't propagate to MCPFailureSummary).

Expected Impact

Removes duplicated struct-field drift risk; small, safe, mechanical refactor with no behavior change (embedding preserves JSON field names and console tags identically).

Suggested Agent

General-purpose / typist-style structural refactor agent.

Estimated Effort

Quick (< 1 hour).

Data Source

DeepReport Intelligence Briefing 2026-08-13 analysis, discussion #52484 (Typist type analysis), verified directly against pkg/cli/logs_models.go.

Generated by 🔬 Deep Report · agent · 253.2 AIC · ⌖ 48.7 AIC · ⊞ 11.4K ·

  • expires on Aug 15, 2026, 7:10 AM UTC-08:00

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions