Step Name Alignment Issues
Found in: pkg/workflow/docker_sbx_install.go (compiler source), propagating into ~30 compiled .lock.yml files including .github/workflows/daily-action-setup-security-audit.lock.yml
Summary
One compiler-generated step name breaks the Title Case convention used consistently by every other step name in the codebase (verified: across the full step-name manifest, this is the only step name in any .lock.yml that starts with a lowercase letter).
Issues Identified
1. [Medium Priority] Capitalization inconsistency: "docker-sbx pre-flight smoke test"
Current step name (source):
pkg/workflow/docker_sbx_install.go:114 — " - name: docker-sbx pre-flight smoke test",
Sibling steps in the same generated block (all Title Case):
- Line 36:
Check KVM availability for docker-sbx
- Line 46/60:
Check Docker Hub secrets for docker-sbx
- Line 75:
Install docker-sbx
- Line 86:
Start docker-sbx daemon and authenticate
- Line 114:
docker-sbx pre-flight smoke test ← inconsistent
Issue:
Every other step name in this file (and virtually every step name across the whole compiled workflow corpus) begins with a capitalized imperative verb (Check, Install, Start, Setup, Configure, ...). This one step starts lowercase with docker-sbx, breaking both the Title Case convention and the "verb-first" pattern used by its immediate neighbors.
Suggested improvement:
docker-sbx pre-flight smoke test → Run docker-sbx pre-flight smoke test
Related log line: pkg/workflow/docker_sbx_install.go:112 also uses lowercase in its log message ("Generating docker-sbx pre-flight smoke test step") — cosmetic only, not a compiled step name, so lower priority to touch but can be updated for consistency in the same PR.
Agentic Task Description
To fix this:
- Edit
pkg/workflow/docker_sbx_install.go line 114, changing the step name string to " - name: Run docker-sbx pre-flight smoke test",
- Check
pkg/workflow/docker_sbx_test.go for any assertions on the literal step name string and update them to match
- Recompile all workflows (
make recompile or equivalent) so the ~30 affected .lock.yml files pick up the new name
- Verify no other code (e.g., log parsing, step-name-based lookups) depends on the exact old string
Related Files
- Source:
pkg/workflow/docker_sbx_install.go
- Test:
pkg/workflow/docker_sbx_test.go
- Compiled (sample):
.github/workflows/daily-action-setup-security-audit.lock.yml
- Project glossary:
docs/src/content/docs/reference/glossary.md
Priority
This issue is Medium Priority — a single, isolated capitalization anti-pattern with a trivial fix and no functional impact, but a real and easily-verified inconsistency against the established naming convention.
AI generated by Step Name Alignment for daily maintenance
Generated by 📋 Step Name Alignment · agent · 90.8 AIC · ⌖ 34.7 AIC · ⊞ 10.1K · ◷
Step Name Alignment Issues
Found in:
pkg/workflow/docker_sbx_install.go(compiler source), propagating into ~30 compiled.lock.ymlfiles including.github/workflows/daily-action-setup-security-audit.lock.ymlSummary
One compiler-generated step name breaks the Title Case convention used consistently by every other step name in the codebase (verified: across the full step-name manifest, this is the only step name in any
.lock.ymlthat starts with a lowercase letter).Issues Identified
1. [Medium Priority] Capitalization inconsistency: "docker-sbx pre-flight smoke test"
Current step name (source):
pkg/workflow/docker_sbx_install.go:114—" - name: docker-sbx pre-flight smoke test",Sibling steps in the same generated block (all Title Case):
Check KVM availability for docker-sbxCheck Docker Hub secrets for docker-sbxInstall docker-sbxStart docker-sbx daemon and authenticatedocker-sbx pre-flight smoke test← inconsistentIssue:
Every other step name in this file (and virtually every step name across the whole compiled workflow corpus) begins with a capitalized imperative verb (
Check,Install,Start,Setup,Configure, ...). This one step starts lowercase withdocker-sbx, breaking both the Title Case convention and the "verb-first" pattern used by its immediate neighbors.Suggested improvement:
docker-sbx pre-flight smoke test→Run docker-sbx pre-flight smoke testRelated log line:
pkg/workflow/docker_sbx_install.go:112also uses lowercase in its log message ("Generating docker-sbx pre-flight smoke test step") — cosmetic only, not a compiled step name, so lower priority to touch but can be updated for consistency in the same PR.Agentic Task Description
To fix this:
pkg/workflow/docker_sbx_install.goline 114, changing the step name string to" - name: Run docker-sbx pre-flight smoke test",pkg/workflow/docker_sbx_test.gofor any assertions on the literal step name string and update them to matchmake recompileor equivalent) so the ~30 affected.lock.ymlfiles pick up the new nameRelated Files
pkg/workflow/docker_sbx_install.gopkg/workflow/docker_sbx_test.go.github/workflows/daily-action-setup-security-audit.lock.ymldocs/src/content/docs/reference/glossary.mdPriority
This issue is Medium Priority — a single, isolated capitalization anti-pattern with a trivial fix and no functional impact, but a real and easily-verified inconsistency against the established naming convention.