Skip to content

[Code Quality] Fix schema-diff parser_yaml_fields always empty, causing false-positive field gap reports #50209

Description

@github-actions

Description

Schema consistency audit found that the pre-computed parser field diff used by schema-drift tooling is unreliable: /tmp/gh-aw/agent/schema-diff.json reports parser_yaml_fields: [] even though pkg/workflow/frontmatter_types.go and pkg/workflow/frontmatter_serialization.go clearly handle many frontmatter fields. This causes every schema field to appear in field_gaps.in_schema_not_parser, so any automation trusting that output over-reports inconsistencies and mis-prioritizes real schema drift.

Suggested Changes

  • Locate the generator for schema-diff.json (or the workflow/script producing parser_yaml_fields) and fix the field extraction so it actually enumerates fields handled in frontmatter_types.go / frontmatter_serialization.go.
  • Add a regression check (unit test or script assertion) verifying parser_yaml_fields is non-empty and includes known fields (e.g. on, engine, tools).

Files Affected

  • Schema-diff generation tooling (search for parser_yaml_fields producer, likely under .github/aw/ or a Go analysis script)
  • pkg/workflow/frontmatter_types.go, pkg/workflow/frontmatter_serialization.go (reference implementation)

Success Criteria

  • schema-diff.json reports non-empty parser_yaml_fields.
  • field_gaps.in_schema_not_parser no longer contains fields that are actually implemented.
  • Existing schema/doc consistency checks pass.

Source

Extracted from Schema Consistency audit - 2026-08-04 (discussion #50195)

Priority

Medium - affects reliability of downstream automation/reporting, not user-facing.

🔍 Task mining by Discussion Task Miner - Code Quality Improvement Agent · auto · 48.1 AIC · ⌖ 4.53 AIC · ⊞ 10.3K · ◷

  • expires on Aug 4, 2026, 11:42 PM UTC-08:00

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions