Summary
Custom lint scan found 42 non-largefunc performance/style findings that mostly share one root cause: repeated string concatenation with += inside loops.
Breakdown:
- 41x
+= string-in-loop findings that should become strings.Builder usage
- 1x map-set allocation finding (
map[string]bool used as a set)
Hotspots:
pkg/workflow/checkout_config_parser.go — 10 findingspkg/cli/audit_report_render.go — 8 findingspkg/cli/bootstrap_config.go — 4 findings- several smaller occurrences across
pkg/workflow and pkg/cli
pkg/actionpins/actionpins_internal_test.go:173 — replace map[string]bool set usage with map[string]struct{}
Representative diagnostics:
pkg/workflow/checkout_config_parser.go:316 — string concatenation with += inside a loop allocates O(n2) bytes; use strings.Builderpkg/cli/audit_report_render.go — multiple repeated loop concatenation findingspkg/actionpins/actionpins_internal_test.go:173 — use map[string]struct{} for a set
Expected outcome
Convert loop-based string building to strings.Builder (or equivalent minimal fix) and update the one set-like map allocation pattern.
Remediation checklist
Generated by 🧌 LintMonster · gpt54 · 35.3 AIC · ⌖ 7.93 AIC · ⊞ 5.3K · ◷
Summary
Custom lint scan found 42 non-
largefuncperformance/style findings that mostly share one root cause: repeated string concatenation with+=inside loops.Breakdown:
+=string-in-loop findings that should becomestrings.Builderusagemap[string]boolused as a set)Hotspots:
pkg/workflow/checkout_config_parser.go— 10 findingspkg/cli/audit_report_render.go— 8 findingspkg/cli/bootstrap_config.go— 4 findingspkg/workflowandpkg/clipkg/actionpins/actionpins_internal_test.go:173— replacemap[string]boolset usage withmap[string]struct{}Representative diagnostics:
pkg/workflow/checkout_config_parser.go:316— string concatenation with+=inside a loop allocates O(n2) bytes; usestrings.Builderpkg/cli/audit_report_render.go— multiple repeated loop concatenation findingspkg/actionpins/actionpins_internal_test.go:173— usemap[string]struct{}for a setExpected outcome
Convert loop-based string building to
strings.Builder(or equivalent minimal fix) and update the one set-like map allocation pattern.Remediation checklist
strings.Builderfor loop-accumulated strings; preserve exact output.map[string]boolset usage withmap[string]struct{}where no boolean state is needed.largefuncrefactors in this issue.make golint-custom.