Skip to content

[sighthound] Security findings in github/gh-aw #48777

Description

@github-actions

Sighthound scan flagged 142 findings; below are the top 5 highest-severity, non-test findings from actionable.json requiring triage.

  1. Path Traversal (High)pkg/cli/download_workflow.go:105
    A filesystem path is derived from untrusted input. Remediate by resolving with filepath.Clean and confining the result to a base directory before opening.

  2. Path Traversal (High)scripts/generate-agent-factory.js:217,223,232
    Untrusted values are joined into filesystem paths without validation in three locations. Validate/normalize path segments and reject ../ traversal before use.

  3. Cross-Site Scripting (High)pkg/cli/logs_format_compact.go:193
    Untrusted data is written directly into an HTTP response without HTML escaping. Use html/template or html.EscapeString to sanitize output.

  4. Code Injection / SSTI (High)pkg/cli/bootstrap_profile_helpers.go:258
    A template is parsed from dynamic input, enabling server-side template injection. Templates must be static; pass untrusted data only as escaped template data, not as template source.

  5. SSRF (High)scripts/ensure-docs-slide-pdf.js:110
    A caller-controlled URL is passed to an outbound HTTP request. Validate/allowlist target hosts/schemes before making the request.

Note: Several Command Injection findings (e.g. runner_guard.go:94, grant.go:159, poutine.go) use exec.Command with fixed argument slices (no shell interpolation) and may be false positives worth a quick manual check rather than immediate action. Full details in /tmp/gh-aw/agent/sighthound/actionable.json (142 findings total, pre-filtered to exclude test/testdata paths).

Generated by 🛡️ Sighthound Security Scan · sonnet50 · 22.7 AIC · ⌖ 7.75 AIC · ⊞ 7.1K ·

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions