Skip to content

[lint-monster] Function-length refactoring backlog (2026-07-26) #48111

Description

@github-actions

Daily lint scan summary

Custom lint scan on 2026-07-26 found 664 shared largefunc findings in the consolidated function-length refactoring backlog: 285 in pkg/workflow and 379 in pkg/cli. Per policy, all long-function findings under pkg/workflow and pkg/cli are tracked as one shared topic with exactly one authoritative open issue.

Current authoritative count

  • Total findings: 664
  • pkg/workflow/**: 285
  • pkg/cli/**: 379

Representative diagnostics

  • pkg/workflow/antigravity_engine.go:155GetExecutionSteps is 204 lines long
  • pkg/workflow/awf_helpers.go:229BuildAWFCommand is 372 lines long
  • pkg/workflow/compiler_safe_outputs_job.go:269buildSafeOutputsHandlerOutputsAndActionSteps is 220 lines long
  • pkg/workflow/unified_prompt_step.go:266generateUnifiedPromptCreationStep is 259 lines long
  • pkg/cli/add_interactive_git.go:26createWorkflowPRAndConfigureSecret is 171 lines long
  • pkg/cli/audit_diff.go:67computeFirewallDiff is 144 lines long
  • pkg/cli/add_interactive_workflow.go:17checkStatusAndOfferRun is 146 lines long

Expected outcome

Reduce the pkg/workflow and pkg/cli largefunc backlog incrementally by extracting focused helpers and smaller phases while preserving behavior. Keep this issue authoritative for the shared function-length topic instead of opening separate pkg/workflow vs pkg/cli tracking issues.

Remediation checklist

  • Keep edits scoped only to the assigned lint slice
  • Prefer minimal helper extraction and cohesive phase splits
  • Avoid unrelated cleanup outside the chosen slice
  • Validate fixes by running make golint-custom

Next slices to refactor

  • pkg/workflow/compiler_* builders and YAML generation hotspots
  • pkg/workflow/safe_outputs_* config and job builders
  • pkg/workflow/frontmatter_*, tools*, and mcp_* clusters
  • pkg/cli/audit_* reporting and diff/render helpers
  • pkg/cli/add_* interactive/setup flows
  • pkg/cli/codemod_* helpers and related orchestration code

Fused guidance for the assignee

  • Keep remediation scoped to findings in the assigned lint slice only.
  • Prefer minimal, targeted code edits and helper extraction over broad rewrites.
  • Validate with make golint-custom before handoff.

Duplicate issues linked/closed

  • None found; only historical closed lint-monster function-length trackers were present at triage time.

Generated by 🧌 LintMonster · gpt54 · 19.2 AIC · ⌖ 4.72 AIC · ⊞ 4.6K ·

  • expires on Aug 1, 2026, 7:47 PM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions