Skip to content

[lint-monster] function-length refactoring backlog (659 findings in pkg/workflow and pkg/cli) #47448

Description

@github-actions

Summary

The latest make golint-custom run reports 659 function-length findings that should be tracked as a single shared backlog for pkg/workflow and pkg/cli.

  • pkg/workflow: 284 findings
  • pkg/cli: 375 findings
  • Scope rule: treat all largefunc / long-function findings in these paths as one consolidated topic

Representative diagnostics:

  • pkg/workflow/antigravity_engine.go:155: GetExecutionSteps is 204 lines long (limit: 60)
  • pkg/workflow/awf_helpers.go:229: BuildAWFCommand is 372 lines long (limit: 60)
  • pkg/workflow/compiler_safe_outputs_job.go:269: buildSafeOutputsHandlerOutputsAndActionSteps is 220 lines long (limit: 60)
  • pkg/cli/add_interactive_git.go:26: createWorkflowPRAndConfigureSecret is 171 lines long (limit: 60)
  • pkg/cli/audit_report.go:695: extractPreAgentStepErrors is 189 lines long (limit: 60)

Expected outcome

Refactor long functions into smaller helpers without changing behavior, while reducing the current 659-finding backlog over multiple slices.

Remediation checklist

  • Work only on the function-length findings in this shared backlog
  • Prefer minimal, targeted refactors that extract cohesive helper functions
  • Group related extractions by local responsibility and keep behavior unchanged
  • Favor new focused files/helpers when that improves code organization
  • Validate each slice with make golint-custom

Suggested next slices

  • Slice 1: high-churn pkg/cli entrypoints and bootstrap helpers
  • Slice 2: engine execution step builders in pkg/workflow
  • Slice 3: safe outputs compilation/rendering helpers in pkg/workflow
  • Slice 4: parser/validation helpers in pkg/workflow
  • Slice 5: remaining backlog by subsystem after re-counting

Skill-fused guidance for the assignee

  • Validate fixes by running make golint-custom
  • Keep remediation scoped to this lint group
  • Prefer minimal, targeted code edits
  • Follow repository file-organization guidance: extract small focused helpers/files rather than growing large monoliths

Generated by 🧌 LintMonster · gpt54 26.3 AIC · ⌖ 7.47 AIC · ⊞ 4.5K ·

  • expires on Jul 29, 2026, 7:45 PM UTC-08:00

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions