[log] Add debug logging to config server_type helpers - #11586
Conversation
Adds logConfig debug logging calls to IsStdioServerType and NormalizeServerType in internal/config/server_type.go, reusing the existing package-level logConfig logger for consistency with other config files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds debug visibility to server-type classification and normalization.
Changes:
- Logs classification results.
- Logs normalization decisions using
logConfig.
Show a summary per file
| File | Description |
|---|---|
internal/config/server_type.go |
Adds debug logging to server-type helpers. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
🔒 mcpg Read-Only Stress — gVisorSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: INCONCLUSIVE
No FAIL conditions triggered. No issue/comment/reaction/branch/file/PR was created.
|
🔒 mcpg Read-Only Stress — default AWFSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: INCONCLUSIVE
No writes leaked. Run ID: §32429048514
|
🔒 mcpg Read-Only Stress — docker-sbxSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: INCONCLUSIVE Notes:
|
Summary
Adds debug logging to
internal/config/server_type.go, which previously had zero logging calls.Changes
IsStdioServerType: logs the input type and the resulting boolean classification.NormalizeServerType: logs whether the type was normalized to"stdio"or left unchanged.Both functions reuse the existing package-level
logConfiglogger (config:confignamespace, declared ininternal/config/config_core.go) rather than declaring a new logger, keeping the file consistent with the rest of theconfigpackage.Validation
go build ./...— passesgo vet ./internal/config/...— passesgo test ./internal/config/...— passes (ok)Only
internal/config/server_type.gowas modified; no test files or unrelated files were touched.