Skip to content

Fix release workflow timeout and gating failures - #10944

Merged
lpcox merged 1 commit into
mainfrom
fix-release-timeouts
Aug 9, 2026
Merged

Fix release workflow timeout and gating failures#10944
lpcox merged 1 commit into
mainfrom
fix-release-timeouts

Conversation

@lpcox

@lpcox lpcox commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • update launcher and OIDC HTTP test fixtures for the go-sdk v1.7 discovery handshake, avoiding 30-second transport fallback waits
  • ensure launcher tests clean up cached HTTP connections
  • prevent manual release jobs from running when tests fail and create-tag is skipped
  • regenerate release.lock.yml

Fixes the failures observed in https://github.com/github/gh-aw-mcpg/actions/runs/31332851929.

Validation

  • make agent-finished
  • gh aw compile release --strict

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 6cacb949-70fa-49c3-b303-bcbb33f77a4e
Copilot AI balanced review requested due to automatic review settings August 9, 2026 20:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes go-sdk v1.7 test delays and prevents releases after failed manual validation.

Changes:

  • Handle discovery probes and dynamic JSON-RPC IDs in HTTP fixtures.
  • Close cached launcher connections during tests.
  • Strengthen release-job gating and regenerate the workflow.
Show a summary per file
File Description
internal/mcp/oidc_connection_test.go Updates OIDC test handshake responses.
internal/launcher/launcher_test.go Adds reusable handshake-aware fixtures and cleanup.
.github/workflows/release.md Corrects manual and tag-release gating.
.github/workflows/release.lock.yml Regenerates the compiled workflow.

Review details

Tip

Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

🔒 mcpg Read-Only Stress — gVisor

Surface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Isolation runtime: gVisor (runsc) kernel-level isolation

Part Surface Op Result Expected Status
A MCP reads (list_issues, list_pull_requests, get_file_contents, list_commits) data returned ALLOWED
B MCP writes (reaction/star/issue/comment/branch/file/PR) all 7 blocked with [-32602] unknown tool BLOCKED
C CLI reads (list_issues, get_file_contents, list_pull_requests, list_commits) data returned ALLOWED
D CLI REST writes (reaction/star/issue/comment/file) refused — gh unauthenticated (no GH_TOKEN) BLOCKED
E CLI GraphQL mutations (addReaction/addStar/createIssue) refused — gh unauthenticated (no GH_TOKEN) BLOCKED

Gateway tool surface: 22 read-only tools exposed; all write tool names return Error [-32602]: unknown tool at the MCP protocol layer — gateway enforcement, not backend config.

Overall: PASS

References: §31333791615

🔒 mcpg read-only stress (gVisor runtime) by Read-Only Stress: gVisor runtime

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

🔒 mcpg Read-Only Stress — default

Surface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Isolation runtime: default AWF (normal container isolation)

Part Surface Op Result Expected Status
A MCP reads (issues/PRs/README/commits) data returned ALLOWED
B MCP writes (reaction/star/issue/comment/branch/file/PR) gateway Error [-32602]: unknown tool BLOCKED
C CLI reads (list_issues, get_file_contents) data returned ALLOWED
D CLI REST writes (reaction/star/issue/comment/file) gh unauthenticated — no GH_TOKEN BLOCKED
E CLI GraphQL mutations (addReaction/addStar/createIssue) gh unauthenticated — no GH_TOKEN BLOCKED

Overall: PASS

Notes:

  • Part B: Gateway exposes exactly 22 read-only tools. All 7 write tool calls returned MCP error [-32602]: unknown tool — confirming gateway enforcement (tools filtered at gateway level).
  • Parts D/E: gh CLI has no GH_TOKEN in this sandbox; all REST/GraphQL writes rejected before reaching the network.
  • Run: §31333791619

🔒 mcpg read-only stress (default AWF runtime) by Read-Only Stress: default runtime

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

🔒 mcpg Read-Only Stress — docker-sbx

Surface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Isolation runtime: docker-sbx (KVM-isolated microVM)

Part Surface Op Result Expected Status
A MCP reads (issues/PRs/file/commits) data returned ALLOWED
B MCP writes (reaction/star/issue/comment/branch/file/PR) unknown tool — gateway allowlist blocks all 7 BLOCKED
C CLI reads (github CLI list_issues) data returned ALLOWED
D CLI REST writes (reaction/star/issue/comment/file) 401 Bad credentials BLOCKED
E CLI GraphQL mutations (addReaction/addStar/createIssue) 401 Bad credentials BLOCKED

Overall: PASS

Enforcement detail — Part B: gateway tool catalog contains only read-only tools; write tools absent from MCP tool list, returning Error [-32602]: unknown tool. Part D/E: gh CLI unauthenticated, all REST/GraphQL writes rejected with 401.

Run: §31333791612

🔒 mcpg read-only stress (docker-sbx runtime) by Read-Only Stress: docker-sbx runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants