Fix release workflow timeout and gating failures - #10944
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6cacb949-70fa-49c3-b303-bcbb33f77a4e
There was a problem hiding this comment.
Pull request overview
Fixes go-sdk v1.7 test delays and prevents releases after failed manual validation.
Changes:
- Handle discovery probes and dynamic JSON-RPC IDs in HTTP fixtures.
- Close cached launcher connections during tests.
- Strengthen release-job gating and regenerate the workflow.
Show a summary per file
| File | Description |
|---|---|
internal/mcp/oidc_connection_test.go |
Updates OIDC test handshake responses. |
internal/launcher/launcher_test.go |
Adds reusable handshake-aware fixtures and cleanup. |
.github/workflows/release.md |
Corrects manual and tag-release gating. |
.github/workflows/release.lock.yml |
Regenerates the compiled workflow. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
🔒 mcpg Read-Only Stress — gVisorSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Gateway tool surface: 22 read-only tools exposed; all write tool names return Overall: PASS References: §31333791615
|
🔒 mcpg Read-Only Stress — defaultSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS Notes:
|
🔒 mcpg Read-Only Stress — docker-sbxSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS
Run: §31333791612
|
Summary
create-tagis skippedrelease.lock.ymlFixes the failures observed in https://github.com/github/gh-aw-mcpg/actions/runs/31332851929.
Validation
make agent-finishedgh aw compile release --strict