Skip to content

[test-improver] Improve tests for httputil #10547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 1 commit into from
Aug 2, 2026
Merged

[test-improver] Improve tests for httputil #10547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/httputil/tls_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,14 @@ func TestConfigureTLSTrustEnvironment(t *testing.T) {
err := ConfigureTLSTrustEnvironment("/tmp/ca\r.crt")
assert.ErrorContains(t, err, "invalid TLS CA cert path contains newline")
})

t.Run("propagates os.Setenv failure", func(t *testing.T) {
// os.Setenv rejects values containing a NUL byte on all supported
// platforms; this exercises the wrapped-error return branch that is
// otherwise unreachable given the newline/carriage-return guard above.
err := ConfigureTLSTrustEnvironment("/tmp/ca\x00.crt")
require.Error(t, err)
assert.Contains(t, err.Error(), "failed to set")
assert.Contains(t, err.Error(), TLSTrustEnvKeys()[0])
})
}
Loading