Skip to content

docs: fix 'on.release' comment#9455

Merged
felicitymay merged 2 commits intogithub:mainfrom
tchupp:patch-2
Aug 31, 2021
Merged

docs: fix 'on.release' comment#9455
felicitymay merged 2 commits intogithub:mainfrom
tchupp:patch-2

Conversation

@tchupp
Copy link
Copy Markdown
Contributor

@tchupp tchupp commented Aug 31, 2021

Why:

Closes [issue link]

I feel that this change is small enough that it doesn't warrant an issue! I'm happy to create one if necessary

What's being changed:

Correcting a comment in the example for on.release.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Aug 31, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@tchupp
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 31, 2021
Copy link
Copy Markdown
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchupp - thanks for highlighting this typo and submitting a fix for it 💖

Your change looks good. I'll update your branch from main and merge your pull request 🚀

@felicitymay felicitymay enabled auto-merge (squash) August 31, 2021 13:24
@felicitymay felicitymay merged commit 7f35093 into github:main Aug 31, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants