Skip to content

Python: tox is lowercase#9413

Merged
felicitymay merged 2 commits into
github:mainfrom
hugovk:patch-2
Aug 31, 2021
Merged

Python: tox is lowercase#9413
felicitymay merged 2 commits into
github:mainfrom
hugovk:patch-2

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented Aug 29, 2021

Why:

For consistency, spell tox all in lowercase. This is how the tox project spells it, and these docs also have it lowercase in some places.

https://tox.readthedocs.io/

https://twitter.com/jugmac00/status/1431712286557843457

What's being changed:

Change example workflow to use lowercase tox.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Aug 29, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Aug 29, 2021
Copy link
Copy Markdown

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a maintainer of tox, I'd say...

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 30, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@hugovk
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Copy Markdown
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk - thanks for alerting us to this typo and for opening a pull request to fix it 💖

I particularly appreciated the fact that you included links to show how this name is usually capitalized 🙇🏻‍♀️

@jugmac00 - thanks for commenting with your approval too 🚀

@felicitymay felicitymay enabled auto-merge (squash) August 31, 2021 12:30
@felicitymay felicitymay merged commit f05ffd2 into github:main Aug 31, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@hugovk hugovk deleted the patch-2 branch August 31, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants