Skip to content

Change the deprecation note to use past tense#9385

Merged
mchammer01 merged 2 commits intogithub:mainfrom
CyberFlameGO:patch-3
Aug 31, 2021
Merged

Change the deprecation note to use past tense#9385
mchammer01 merged 2 commits intogithub:mainfrom
CyberFlameGO:patch-3

Conversation

@CyberFlameGO
Copy link
Copy Markdown
Contributor

@CyberFlameGO CyberFlameGO commented Aug 27, 2021

Why:

Closes #9384

What's being changed:

The tense of the deprecation note in the article

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Aug 27, 2021
@CyberFlameGO
Copy link
Copy Markdown
Contributor Author

I feel like this article should actually be removed soon, though the button still exists as depicted in this screenshot: image

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 30, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

@CyberFlameGO
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Copy Markdown
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CyberFlameGO - good spot, LGTM ✨
(and yes, the button and section should be removed from the UI)

@mchammer01 mchammer01 enabled auto-merge August 31, 2021 09:06
@mchammer01 mchammer01 merged commit 2aca6db into github:main Aug 31, 2021
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the deprecation note to use past tense

3 participants