Update publishing-java-packages-with-gradle.md#8049
Merged
lecoursen merged 5 commits intogithub:mainfrom Aug 31, 2021
mahozad:patch-2
Merged
Update publishing-java-packages-with-gradle.md#8049lecoursen merged 5 commits intogithub:mainfrom mahozad:patch-2
lecoursen merged 5 commits intogithub:mainfrom
mahozad:patch-2
Conversation
- Merge a somewhat duplicate sentence about setting environment variables in the deploy step - Fix an error in a repository name (Maven Central instead of GitHub Packages) (may have happened because of a copy-paste) - Fix another paragraph that only referred to configuration of GitHub Packages while it was about configuring both Maven Central and GitHub Packages (may have happened because of a copy-paste)
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
Bot
added
the
triage
ramyaparimi
added
actions
Contributor
|
@mahozad Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
The code publishes to both Maven Central AND GitHub Packages so its name would better be "Publish to Maven Central and GitHub Packages" or like previous code snippets simply "Publish package"
lecoursen
previously approved these changes
Aug 31, 2021
lecoursen
previously approved these changes
Aug 31, 2021
lecoursen
reviewed
Aug 31, 2021
lecoursen
approved these changes
Aug 31, 2021
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Closes #8048
What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):