getRequiredEnvParams must be non-empty#85
Merged
rneatherway merged 2 commits intomainfrom Jun 26, 2020
Merged
Conversation
robertbrignull
approved these changes
Jun 26, 2020
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
One minor comment but LGTM regardless.
I've done a very quick audit of the places we call getRequiredEnvParam and all of them should be fine or benefit from requiring the value to be non-empty.
src/util.test.ts
Outdated
| }); | ||
|
|
||
| test('getRef() throws on the empty string', t => { | ||
| for (const input of [""]) { |
Contributor
There was a problem hiding this comment.
Is the use of a loop to make it easier to add new cases? In that case the test name may be a bit too specific. Not a big issue though if you want to keep it this way
rneatherway
force-pushed
the
non-empty-env-vars
branch
from
4030442 to
a0d4330
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist