You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
updateAutomatedSecurityFixes never called when no other repo settings changed #983
updateAutomatedSecurityFixes is only called inside the if (changes.hasChanges) branch in lib/plugins/repository.js. When all other repository settings already match the desired state (i.e. changes.hasChanges === false), the else branch is taken — but that branch only calls updateSecurity (vulnerability alerts). updateAutomatedSecurityFixes is never invoked, so enableAutomatedSecurityFixes: false in settings.yml has no effect.
Relevant code (lib/plugins/repository.js ~line 96, version 2.1.18):
if(changes.hasChanges){// ...promises.push(updateRepoPromise.then(()=>{returnthis.updateSecurity(resp.data,resArray)}))promises.push(updateRepoPromise.then(()=>{returnthis.updateAutomatedSecurityFixes(resp.data,resArray)// ✓ called}))}else{promises.push(this.updateSecurity(resp.data,resArray))// ← updateAutomatedSecurityFixes is missing here}
To reproduce
settings.yml:
repository:
# ... other settings that already match repo state ...security:
enableAutomatedSecurityFixes: false # desired: disabled
Ensure all other repository: settings already match the current repo state so changes.hasChanges is false
Run npm run full-sync
Observe: disableAutomatedSecurityFixes is never called; repos retain their current value
Expected behaviour
updateAutomatedSecurityFixes should be called regardless of whether other repo settings changed — the same way updateSecurity is called in both branches.
Not the exact same problem but an adjacent one related to security settings:
the security_and_analysis is always ignored when doing the comparison for changes.
The only chance for it to be applied is to have a "basic" change (like has_wiki or has_issues) that intersects with the obtained filtered current settings and the settings to applied.
This and the updateAutomatedSecurityFixes problem prevent having a robust solution to set those settings.
Activity
fbelliardtp commentedon Jun 15, 2026
Not the exact same problem but an adjacent one related to security settings:
the
security_and_analysisis always ignored when doing the comparison for changes.The only chance for it to be applied is to have a "basic" change (like
has_wikiorhas_issues) that intersects with the obtained filtered current settings and the settings to applied.This and the
updateAutomatedSecurityFixesproblem prevent having a robust solution to set those settings.