PR comment diff table shows an empty vertical scrollbar due to malformed <tr> markup #1077

Problem Description

What is actually happening

The PR comment posted by safe-settings (the "Safe-Settings config changes detected" comment) shows an HTML <table> for the diff breakdown. This table renders with an unwanted vertical scrollbar even though there's no content that actually needs scrolling — the scrollbar appears to scroll nothing.

Root cause: in lib/settings.js, handleResults() builds this table's rows with a stray <tr> instead of a proper closing </tr>, e.g.:

return `${x}
<tr><td> ✋ </td><td> ${y.plugin} </td>...<td> ${prettify(y.action.modifications)} </td><tr>`

The browser auto-corrects this malformed markup, which leaves a phantom empty <tr></tr> as the last row inside <tbody>. Confirmed directly by fetching the rendered comment HTML via the GitHub API (Accept: application/vnd.github.html+json) — the empty <tr></tr> shows up right before </tbody></table>, inside GitHub's <markdown-accessiblity-table> wrapper component. That malformed trailing row appears to throw off the wrapper's own scroll-affordance measurement, producing the empty scrollbar. The table is also never explicitly closed with </tbody></table> in the source.

What is the expected behavior

The diff table should render without any scrollbar when its content doesn't overflow — no phantom/empty rows, and the table's HTML should be well-formed (each <tr> properly closed, </tbody></table> present).

Error output, if available

N/A — this is a rendering issue, not a thrown error. Confirmed via the rendered comment HTML (GitHub API, `Accept: application/vnd.github.html+json`):

...</pre> </td></tr><tr></tr></tbody></table></markdown-accessiblity-table>

Context

Are you using the hosted instance of probot/settings or running your own?

Running my own instance (local dev, via npm run dev / Probot manifest flow), for testing purposes.

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

0.1.0-rc.26

Version of GitHub Enterprise

N/A (github.com, not GHE)