docs: add source-backed reference gate - #679
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughAdds a generated ChangesSource-backed reference docs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Release Preflight
If this PR is from a |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/check-source-backed-reference.ts`:
- Line 227: The hardcoded CLI source reference in
SourceText('bin/warp-graph.ts') should not rely on a fixed line number for
cliSource.ref(129), since it can drift from the actual error payload. Update the
lookup in check-source-backed-reference.ts to derive the citation from the
expected payload text or verify the line content before creating the reference,
using the cliSource symbol so the docs always point to the correct error block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5b5a71c5-0309-490d-9a7d-fc33f08df8ab
📒 Files selected for processing (8)
CHANGELOG.mdREADME.mddocs/topics/README.mddocs/topics/reference.mdpackage.jsonscripts/check-docs-topology.shscripts/check-source-backed-reference.tsscripts/release-guard.sh
Release Preflight
If this PR is from a |
Code Lawyer Self-Audit Finding@codex please confirm this assessment while I apply the fix.
|
Code Lawyer Activity Summary
No unresolved PR review threads remain at the time of this summary. Proceeding to merge-gate verification. |
Release Preflight
If this PR is from a |
Summary
scripts/check-source-backed-reference.tsand wire it intonpm run lint:docs-topologyIssue
Fixes #670
Test plan
npm run lint:source-backed-referencenpm run lint:docs-topologynpm run lint:md -- README.md CHANGELOG.md docs/topics/README.md docs/topics/reference.mdnpm run lint:md:codenpm run lint -- --no-warn-ignored scripts/check-source-backed-reference.tsnpm run typechecknpm run typecheck:policynpm run test:localnpm run release:guard -- --stage prep-pr --tag v18.1.1ADR checks
Summary by CodeRabbit
New Features
Documentation
Chores