Skip to content

git-cvsexportcommit.perl: Force crlf translation#938

Merged
dscho merged 1 commit into
git-for-windows:masterfrom
virtuald:patch-1
Nov 4, 2016
Merged

git-cvsexportcommit.perl: Force crlf translation#938
dscho merged 1 commit into
git-for-windows:masterfrom
virtuald:patch-1

Conversation

@virtuald
Copy link
Copy Markdown

@virtuald virtuald commented Nov 2, 2016

This fixes a bug encountered when using cvsnt + msys + git. It seems like the output of cvs status had \r\n in it, and caused the command to fail. This fixes that.

@dscho
Copy link
Copy Markdown
Member

dscho commented Nov 3, 2016

As this is Git's own source code, the contribution needs to conform to the Git project's requirements, in particular the commit message. How about this instead?

cvsexportcommit: force crlf translation

When using cvsnt + msys + git, it seems like the output of cvs status
had \r\n in it, and caused the command to fail.

This fixes that.

Signed-off-by: Dustin Spicuzza <dustin@virtualroadside.com>

In addition, I would like to ask whether you tested this in Git for Windows' SDK, using Git's own test suite?

When using cvsnt + msys + git, it seems like the output of cvs status
had \r\n in it, and caused the command to fail.

This fixes that.

Signed-off-by: Dustin Spicuzza <dustin@virtualroadside.com>
@virtuald
Copy link
Copy Markdown
Author

virtuald commented Nov 3, 2016

I've changed the commit as asked.

I did not test it with the test suite, I was hoping that travis-ci or equivalent would do that for me, though now I see that it doesn't run the tests (strange).

@dscho
Copy link
Copy Markdown
Member

dscho commented Nov 3, 2016

I was hoping that travis-ci or equivalent would do that for me

Sadly, we do not have CI running on Windows in place. Yet. Will test manually, but that will have to wait until tomorrow.

@dscho
Copy link
Copy Markdown
Member

dscho commented Nov 4, 2016

Seems to pass. Thanks!

@dscho dscho merged commit ac221b3 into git-for-windows:master Nov 4, 2016
dscho added a commit that referenced this pull request Nov 4, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 5, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 9, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 10, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 10, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Nov 11, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Nov 11, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 11, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 11, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 12, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 13, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 14, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 16, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 29, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit to dscho/git that referenced this pull request Nov 29, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho pushed a commit that referenced this pull request Nov 30, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Dec 6, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Dec 12, 2016
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 11, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 18, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 18, 2017
git-cvsexportcommit.perl: Force crlf translation
git-for-windows-ci pushed a commit that referenced this pull request Jan 18, 2017
git-cvsexportcommit.perl: Force crlf translation
git-for-windows-ci pushed a commit that referenced this pull request Jan 18, 2017
git-cvsexportcommit.perl: Force crlf translation
git-for-windows-ci pushed a commit that referenced this pull request Jan 18, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 24, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 24, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 24, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 25, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 25, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 25, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Jan 25, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit to dscho/git that referenced this pull request Feb 1, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Feb 2, 2017
git-cvsexportcommit.perl: Force crlf translation
git-for-windows-ci pushed a commit that referenced this pull request Feb 2, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Feb 2, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Feb 2, 2017
git-cvsexportcommit.perl: Force crlf translation
git-for-windows-ci pushed a commit that referenced this pull request Feb 2, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Feb 3, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Feb 4, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Feb 4, 2017
git-cvsexportcommit.perl: Force crlf translation
dscho added a commit that referenced this pull request Feb 4, 2017
git-cvsexportcommit.perl: Force crlf translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants