Git for Windows/ARM64 improperly uses `/clangarm64/etc/gitconfig` instead of `/etc/gitconfig`

[dscho]

Actually, I just noticed something: for some reason, the system gitconfig file lives in /etc on x86 installs, but it seems the clangarm64 git expects it in /clangarm64/etc ? In any event, git config --list is empty after that procedure.

Originally posted by @jeremyd2019 in #5292

[rimrul]

Looks like fb5e337 needs a little extension.

[K-Bergmann]

included"std_lib_faciliiies.h"
int main() //C++Programmbeginnenmit der Ausführung von main
{
cout<<"Hello World\n"; //Ausgabe "Hello Word"
keep_window_open();
return 0;

[rimrul]

We'll need to remember to add a follow up like git-for-windows/build-extra#262

[dscho]

We'll need to remember to add a follow up like git-for-windows/build-extra#262

Good point, thank you!

[dscho]

We'll need to remember to add a follow up like git-for-windows/build-extra#262

Good point, thank you!

@rimrul actually, I had a look, and it would appear that I was careful to use whatever git -c core.editor=echo config --system -e would report as the location. Do you see anything that needs to be done in addition?

[rimrul]

Wouldn't we try to restore the settings from the new location when an ARM user upgrades?

[dscho]

Wouldn't we try to restore the settings from the new location when an ARM user upgrades?

Ah. I do not actually think so, we are talking about the system config, and the system config should really be owned by Git for Windows, not by the user. Custom Git configuration goes into ~/.gitconfig, after all.

[rimrul]

Wouldn't we try to restore the settings from the new location when an ARM user upgrades?

Ah. I do not actually think so, we are talking about the system config, and the system config should really be owned by Git for Windows, not by the user. Custom Git configuration goes into ~/.gitconfig, after all.

Yes, but we do try to infer config from the system config in the installer.

[dscho]

Wouldn't we try to restore the settings from the new location when an ARM user upgrades?

Ah. I do not actually think so, we are talking about the system config, and the system config should really be owned by Git for Windows, not by the user. Custom Git configuration goes into ~/.gitconfig, after all.

Yes, but we do try to infer config from the system config in the installer.

We do, indeed. And we do that by running git config -l -z --system. That is done before the previous Git for Windows installation is removed, i.e. it would use the old behavior and retrieve the values from /clangarm64/etc/gitconfig. Then, the installer would first run the uninstaller, and subsequently install the new Git for Windows version, reinstating the system config settings using the new git.exe, i.e. writing into /etc/gitconfig.

So I think this already works as desired.