Support Aarch64Call relocations for Mach-O#465
Merged
Conversation
Contributor
|
Thanks! Based on a brief look this is good. Where was the panic occurring? |
Contributor
|
Ah okay, so not panics, just returning errors (maybe your crate was unwrapping that error). |
Contributor
Author
|
Ah sorry, of course, don't know how I managed to mix that up. (The panic I was seeing was from cranelift unwrapping that error, here to be precise). |
6 tasks
philipc
requested changes
Sep 21, 2022
philipc
approved these changes
Sep 22, 2022
philipc
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I'll merge this after the unrelated archive code has been fixed.
Including calls with arbitrary addends
9c5bdf6 to
76877fe
Compare
Contributor
Author
|
(Rebased so that CI passes now that the formatting issue has been fixed on master) |
mcbegamerxx954
pushed a commit
to mcbegamerxx954/object
that referenced
this pull request
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for relocations with
RelocationEncoding::Aarch64Callon Mach-O. Before this PR we would error out, as the relocation has a size of 26 which was unhandled, and we weren't setting the appropriater_type. After this PR we support relocations withRelocationEncoding::Aarch64Calland an arbitrary addend.This PR also handles a few extra cases of the relocation size (21 and 12) in order to support the usage of Mach-O specific relocations like
ARM64_RELOC_PAGE21andARM64_RELOC_PAGEOFF12, respectively.